[flag_changer refactor] Fix usages to conform with new API

[flag_changer refactor] Fix usages to conform with new API

Fix clients (and clients of their clients) to conform with the new
flag_changer API, namely:

- No need to specify the full path to the command line anymore, just
  the file *name* is enough.
- No need to add "quotes" for values in flags for Android (the same way
  as it works for desktop platforms).

BUG=catapult:#3112

Review-Url: https://codereview.chromium.org/2698703004
Cr-Commit-Position: refs/heads/master@{#451621}
Committed: https://chromium.googlesource.com/chromium/src/+/abf0ba6a507ee0eb418f49829a23caeb29778fd0

[perezju, 2017-02-16 16:36:48]

perezju@chromium.org changed reviewers:
+ jbudorick@chromium.org, lizeb@chromium.org, pasko@chromium.org

[perezju, 2017-02-16 16:36:49]

Please review changes in:
- build/android: jbudorick
- tools/*/*: lizeb, pasko

Thanks!

https://codereview.chromium.org/2698703004/diff/20001/tools/android/loading/c...
File tools/android/loading/controller.py (left):

https://codereview.chromium.org/2698703004/diff/20001/tools/android/loading/c...
tools/android/loading/controller.py:346: subprocess.list2cmdline(chrome_args)))
the flag_changer will also log the set of command lines that were set.

https://codereview.chromium.org/2698703004/diff/20001/tools/android/loading/d...
File tools/android/loading/device_setup.py (right):

https://codereview.chromium.org/2698703004/diff/20001/tools/android/loading/d...
tools/android/loading/device_setup.py:242:
'--host-resolver-rules={}'.format(HOST_RULES)]
no need to special case for mobile platforms anymore, yay!

https://codereview.chromium.org/2698703004/diff/20001/tools/resource_prefetch...
File tools/resource_prefetch_predictor/prefetch_benchmark.py (left):

https://codereview.chromium.org/2698703004/diff/20001/tools/resource_prefetch...
tools/resource_prefetch_predictor/prefetch_benchmark.py:62: chrome_controller =
prefetch_predictor_common.Setup(device, [''])
I assume it wasn't intended to force an "empty" flag to be added?

https://codereview.chromium.org/2698703004/diff/20001/tools/resource_prefetch...
tools/resource_prefetch_predictor/prefetch_benchmark.py:104:
chrome_args.append(_EXTERNAL_PREFETCH_FLAG)
This constant is not defined anywhere.

[jbudorick, 2017-02-16 16:38:50]

On 2017/02/16 16:36:49, perezju wrote:
> Please review changes in:
> - build/android: jbudorick

lgtm

> - tools/*/*: lizeb, pasko
> 
> Thanks!
> 
>
https://codereview.chromium.org/2698703004/diff/20001/tools/android/loading/c...
> File tools/android/loading/controller.py (left):
> 
>
https://codereview.chromium.org/2698703004/diff/20001/tools/android/loading/c...
> tools/android/loading/controller.py:346:
subprocess.list2cmdline(chrome_args)))
> the flag_changer will also log the set of command lines that were set.
> 
>
https://codereview.chromium.org/2698703004/diff/20001/tools/android/loading/d...
> File tools/android/loading/device_setup.py (right):
> 
>
https://codereview.chromium.org/2698703004/diff/20001/tools/android/loading/d...
> tools/android/loading/device_setup.py:242:
> '--host-resolver-rules={}'.format(HOST_RULES)]
> no need to special case for mobile platforms anymore, yay!
> 
>
https://codereview.chromium.org/2698703004/diff/20001/tools/resource_prefetch...
> File tools/resource_prefetch_predictor/prefetch_benchmark.py (left):
> 
>
https://codereview.chromium.org/2698703004/diff/20001/tools/resource_prefetch...
> tools/resource_prefetch_predictor/prefetch_benchmark.py:62: chrome_controller
=
> prefetch_predictor_common.Setup(device, [''])
> I assume it wasn't intended to force an "empty" flag to be added?
> 
>
https://codereview.chromium.org/2698703004/diff/20001/tools/resource_prefetch...
> tools/resource_prefetch_predictor/prefetch_benchmark.py:104:
> chrome_args.append(_EXTERNAL_PREFETCH_FLAG)
> This constant is not defined anywhere.

[Benoit L, 2017-02-17 09:32:51]

Thank you!
lgtm

[pasko, 2017-02-17 13:30:25]

lgtm

https://codereview.chromium.org/2698703004/diff/20001/tools/resource_prefetch...
File tools/resource_prefetch_predictor/prefetch_benchmark.py (left):

https://codereview.chromium.org/2698703004/diff/20001/tools/resource_prefetch...
tools/resource_prefetch_predictor/prefetch_benchmark.py:62: chrome_controller =
prefetch_predictor_common.Setup(device, [''])
On 2017/02/16 16:36:49, perezju wrote:
> I assume it wasn't intended to force an "empty" flag to be added?

no, I think it was a leftover from what lizeb@ experimented with, and I missed
it during review

https://codereview.chromium.org/2698703004/diff/20001/tools/resource_prefetch...
tools/resource_prefetch_predictor/prefetch_benchmark.py:104:
chrome_args.append(_EXTERNAL_PREFETCH_FLAG)
On 2017/02/16 16:36:49, perezju wrote:
> This constant is not defined anywhere.

thanks! indeed it is done differently since
https://codereview.chromium.org/2652313002

[perezju, 2017-02-20 09:40:46]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-02-20 09:41:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 09:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 09:43:00]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[perezju, 2017-02-20 12:07:56]

The CQ bit was checked by perezju@chromium.org

[perezju, 2017-02-20 12:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org,
lizeb@chromium.org, jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2698703004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-20 12:08:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 13:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 13:35:49]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[perezju, 2017-02-20 13:55:38]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-02-20 13:55:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 14:23:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487598938342780,
"parent_rev": "e7b3dee936f49e075374368c815c92cb292e73e4", "commit_rev":
"abf0ba6a507ee0eb418f49829a23caeb29778fd0"}

[commit-bot: I haz the power, 2017-02-20 14:24:04]

Description was changed from

==========
[flag_changer refactor] Fix usages to conform with new API

Fix clients (and clients of their clients) to conform with the new
flag_changer API, namely:

- No need to specify the full path to the command line anymore, just
  the file *name* is enough.
- No need to add "quotes" for values in flags for Android (the same way
  as it works for desktop platforms).

BUG=catapult:#3112
==========

to

==========
[flag_changer refactor] Fix usages to conform with new API

Fix clients (and clients of their clients) to conform with the new
flag_changer API, namely:

- No need to specify the full path to the command line anymore, just
  the file *name* is enough.
- No need to add "quotes" for values in flags for Android (the same way
  as it works for desktop platforms).

BUG=catapult:#3112

Review-Url: https://codereview.chromium.org/2698703004
Cr-Commit-Position: refs/heads/master@{#451621}
Committed:
https://chromium.googlesource.com/chromium/src/+/abf0ba6a507ee0eb418f49829a23...
==========

[commit-bot: I haz the power, 2017-02-20 14:24:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/abf0ba6a507ee0eb418f49829a23...