Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/resource_prefetch_predictor/prefetch_benchmark.py

Issue 2698703004: [flag_changer refactor] Fix usages to conform with new API (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/resource_prefetch_predictor/generate_test_data.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/resource_prefetch_predictor/prefetch_benchmark.py
diff --git a/tools/resource_prefetch_predictor/prefetch_benchmark.py b/tools/resource_prefetch_predictor/prefetch_benchmark.py
index 586c2ebbfd7ec4087a7f1a7a324a7203280a47e0..e31bd1d1ad212a27f127fe1de5b71aa29b151ebf 100755
--- a/tools/resource_prefetch_predictor/prefetch_benchmark.py
+++ b/tools/resource_prefetch_predictor/prefetch_benchmark.py
@@ -59,7 +59,7 @@ def _CreateArgumentParser():
def _Setup(device, database_filename):
"""Sets up a device and returns an instance of RemoteChromeController."""
- chrome_controller = prefetch_predictor_common.Setup(device, [''])
+ chrome_controller = prefetch_predictor_common.Setup(device)
chrome_package = OPTIONS.ChromePackage()
device.ForceStop(chrome_package.package)
chrome_controller.ResetBrowserState()
@@ -68,9 +68,8 @@ def _Setup(device, database_filename):
# Make sure that the speculative prefetch predictor is enabled to ensure
# that the disk database is re-created.
- command_line_path = '/data/local/tmp/chrome-command-line'
with device_setup.FlagReplacer(
- device, command_line_path, ['--disable-fre']):
+ device, chrome_package.cmdline_file, ['--disable-fre']):
# Launch Chrome for the first time to recreate the local state.
launch_intent = intent.Intent(
action='android.intent.action.MAIN',
@@ -104,7 +103,7 @@ def _RunOnce(device, database_filename, url, prefetch_delay_ms,
chrome_args.extend([
'--force-fieldtrials=trial/group',
'--force-fieldtrial-params=trial.group:mode/external-prefetching',
- '--enable-features="SpeculativeResourcePrefetching<trial"'])
+ '--enable-features=SpeculativeResourcePrefetching<trial'])
chrome_controller = controller.RemoteChromeController(device)
device.ForceStop(OPTIONS.ChromePackage().package)
« no previous file with comments | « tools/resource_prefetch_predictor/generate_test_data.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698