Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: tools/android/loading/controller.py

Issue 2698703004: [flag_changer refactor] Fix usages to conform with new API (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/android/loading/controller.py
diff --git a/tools/android/loading/controller.py b/tools/android/loading/controller.py
index bbd4799ac1470b9e264b4dc3caefd8cf570c215a..ace200b038a8e72f7e33da331c6d54f0b7a33c9f 100644
--- a/tools/android/loading/controller.py
+++ b/tools/android/loading/controller.py
@@ -339,13 +339,9 @@ class RemoteChromeController(ChromeControllerBase):
assert self._wpr_attributes.chrome_env_override == {}, \
'Remote controller doesn\'t support chrome environment variables.'
package_info = OPTIONS.ChromePackage()
- command_line_path = '/data/local/tmp/chrome-command-line'
self._device.ForceStop(package_info.package)
- chrome_args = self._GetChromeArguments()
- logging.info('Launching %s with flags: %s' % (package_info.package,
- subprocess.list2cmdline(chrome_args)))
with device_setup.FlagReplacer(
- self._device, command_line_path, self._GetChromeArguments()):
+ self._device, package_info.cmdline_file, self._GetChromeArguments()):
self._DismissCrashDialogIfNeeded()
start_intent = intent.Intent(
package=package_info.package, activity=package_info.activity,
« no previous file with comments | « tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py ('k') | tools/android/loading/device_setup.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698