Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2698153002: Enforce limits on configs (Closed)

Created:
3 years, 10 months ago by smut
Modified:
3 years, 10 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Enforce limits on configs 10 for instance templates (arbitrarily chosen based on current usage) and 1000 for instances per instance group (GCE-enforced limit). BUG=692425, 692428 Review-Url: https://codereview.chromium.org/2698153002 Committed: https://github.com/luci/luci-py/commit/4ac1c3735889aa3e743cf2d9ad23f65998a87f73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
M appengine/gce-backend/config.py View 2 chunks +18 lines, -0 lines 0 comments Download
M appengine/gce-backend/config_test.py View 2 chunks +82 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
smut
3 years, 10 months ago (2017-02-16 02:22:44 UTC) #3
Vadim Sh.
lgtm
3 years, 10 months ago (2017-02-16 02:38:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698153002/20001
3 years, 10 months ago (2017-02-16 23:03:27 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 23:05:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://github.com/luci/luci-py/commit/4ac1c3735889aa3e743cf2d9ad23f65998a87f73

Powered by Google App Engine
This is Rietveld 408576698