Enforce limits on configs

appengine/gce-backend/config_test.py

 #!/usr/bin/python
 # Copyright 2016 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """Unit tests for config.py."""
 
 import logging
 import unittest
 
@@ skipping 89 matching lines @@
             ),
         ],
     )
     self.install_mock(template_config=template_config)
 
     config.update_template_configs()
     self.failIf(config.Configuration.cached().template_config)
     self.failIf(config.Configuration.cached().manager_config)
     self.failIf(config.Configuration.cached().revision)
 
+  def test_too_many_instance_templates(self):
+    template_config = config_pb2.InstanceTemplateConfig(
+      templates=[
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-1',
+            ),
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-2',
+            ),
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-3',
+            ),
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-4',
+            ),
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-5',
+            ),
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-6',
+            ),
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-7',
+            ),
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-8',
+            ),
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-9',
+            ),
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-10',
+            ),
+            config_pb2.InstanceTemplateConfig.InstanceTemplate(
+                base_name='base-name-11',
+            ),
+      ],
+    )
+    self.install_mock(template_config=template_config)
+
+    config.update_template_configs()
+    self.failIf(config.Configuration.cached().template_config)
+    self.failIf(config.Configuration.cached().manager_config)
+    self.failIf(config.Configuration.cached().revision)
+
   def test_repeated_zone_different_base_name(self):
     """Ensures repeated zones in different base names are valid."""
     manager_config = config_pb2.InstanceGroupManagerConfig(
         managers=[
             config_pb2.InstanceGroupManagerConfig.InstanceGroupManager(
                 template_base_name='base-name-1',
                 zone='us-central1-a',
             ),
             config_pb2.InstanceGroupManagerConfig.InstanceGroupManager(
                 template_base_name='base-name-2',
@@ skipping 30 matching lines @@
             ),
         ],
     )
     self.install_mock(manager_config=manager_config)
 
     config.update_template_configs()
     self.failIf(config.Configuration.cached().template_config)
     self.failIf(config.Configuration.cached().manager_config)
     self.failIf(config.Configuration.cached().revision)
 
+  def test_minimum_size_exceeds_maximum_size(self):
+    """Ensures repeated zones in a base name reject the entire config."""
+    manager_config = config_pb2.InstanceGroupManagerConfig(
+        managers=[
+            config_pb2.InstanceGroupManagerConfig.InstanceGroupManager(
+                maximum_size=1,
+                minimum_size=2,
+                template_base_name='base-name-1',
+                zone='us-central1-a',
+            ),
+        ],
+    )
+    self.install_mock(manager_config=manager_config)
+
+    config.update_template_configs()
+    self.failIf(config.Configuration.cached().template_config)
+    self.failIf(config.Configuration.cached().manager_config)
+    self.failIf(config.Configuration.cached().revision)
+
+  def test_maximum_size_exceeds_maximum_allowed(self):
+    """Ensures repeated zones in a base name reject the entire config."""
+    manager_config = config_pb2.InstanceGroupManagerConfig(
+        managers=[
+            config_pb2.InstanceGroupManagerConfig.InstanceGroupManager(
+                maximum_size=9999,
+                template_base_name='base-name-1',
+                zone='us-central1-a',
+            ),
+        ],
+    )
+    self.install_mock(manager_config=manager_config)
+
+    config.update_template_configs()
+    self.failIf(config.Configuration.cached().template_config)
+    self.failIf(config.Configuration.cached().manager_config)
+    self.failIf(config.Configuration.cached().revision)
+
   def test_update_template_configs(self):
     """Ensures config is updated when revision changes."""
     manager_config = config_pb2.InstanceGroupManagerConfig(
         managers=[config_pb2.InstanceGroupManagerConfig.InstanceGroupManager()],
     )
     self.install_mock(revision='revision-1', manager_config=manager_config)
 
     config.update_template_configs()
     self.failIf(config.Configuration.cached().template_config)
     self.failUnless(config.Configuration.cached().manager_config)
@@ skipping 58 matching lines @@
         config_pb2.SettingsCfg(mp_server='http://url'),
         ['mp_server must start with "https://" or "http://localhost"'])
     self.validator_test(
         config.validate_settings_config,
         config_pb2.SettingsCfg(mp_server='url'),
         ['mp_server must start with "https://" or "http://localhost"'])
 
 
 if __name__ == '__main__':
   unittest.main()