Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: appengine/gce-backend/config.py

Issue 2698153002: Enforce limits on configs (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/gce-backend/config_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/gce-backend/config.py
diff --git a/appengine/gce-backend/config.py b/appengine/gce-backend/config.py
index 5e51b9f18d199071fe07df89744c2ee8f5a81f42..a64883ac26024e752cac0cf4ca361c4a9bee60aa 100644
--- a/appengine/gce-backend/config.py
+++ b/appengine/gce-backend/config.py
@@ -131,6 +131,9 @@ def validate_template_config(config, context):
valid = False
else:
base_names.add(template.base_name)
+ if len(base_names) > 10:
+ context.error('Too many instance templates.')
+ valid = False
metrics.config_valid.set(valid, fields={'config': TEMPLATES_CFG_FILENAME})
@@ -152,6 +155,21 @@ def validate_manager_config(config, context):
valid = False
else:
zones[manager.template_base_name].add(manager.zone)
+ if manager.minimum_size > manager.maximum_size:
+ context.error(
+ 'minimum_size > maximum_size for zone %s in template %s.',
+ manager.zone,
+ manager.template_base_name,
+ )
+ valid = False
+ if manager.maximum_size > 1000:
+ # A GCE InstanceGroup is limited to 1000 instances.
+ context.error(
+ 'maximum_size > 1000 for zone %s in template %s.',
+ manager.zone,
+ manager.template_base_name,
+ )
+ valid = False
metrics.config_valid.set(valid, fields={'config': MANAGERS_CFG_FILENAME})
« no previous file with comments | « no previous file | appengine/gce-backend/config_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698