Make the navigator.usb attribute accessible only in secure contexts.

Make the navigator.usb attribute accessible only in secure contexts.

Instead of performing secure context checks inside every method of the
USB object this change removes it from the Navigator object when not in
a secure context. This is equivalent to adding the [SecureContext]
extended attribute to the NavigatorUSB interface but the WebIDL code
generator doesn't support mixing it with [OriginTrialEnabled]. Instead
the secure context check is added to the hand-written Origin Trial code
in ConditionalFeaturesForModules.cpp.

BUG=691031
Review-Url: https://codereview.chromium.org/2698083008
Cr-Commit-Position: refs/heads/master@{#452256}
Committed: https://chromium.googlesource.com/chromium/src/+/9a05ae84e268e91f39a684bc565484110c16da1b

[Reilly Grant (use Gerrit), 2017-02-17 20:34:30]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 20:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 22:49:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 22:49:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2017-02-17 23:12:37]

Moved [NoInterfaceObject] change to a separate patch.

[Reilly Grant (use Gerrit), 2017-02-17 23:16:22]

reillyg@chromium.org changed reviewers:
+ mkwst@chromium.org

[Reilly Grant (use Gerrit), 2017-02-17 23:16:22]

PTAL

[Reilly Grant (use Gerrit), 2017-02-17 23:16:30]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[Reilly Grant (use Gerrit), 2017-02-17 23:16:39]

Description was changed from

==========
Make the navigator.usb attribute accessible only in secure contexts.

Instead of performing secure context checks inside every method of the
USB object this change removes it from the Navigator object when not in
a secure context. This is equivalent to adding the [SecureContext]
extended attribute to the NavigatorUSB interface but the WebIDL code
generator doesn't support mixing it with [OriginTrialEnabled]. Instead
the secure context check is added to the hand-written Origin Trial code
in ConditionalFeaturesForModules.cpp.

The [NoInterfaceObject] attribute has been removed from the USB
interface to match the spec and because it enables the new LayoutTests.

BUG=691031
==========

to

==========
Make the navigator.usb attribute accessible only in secure contexts.

Instead of performing secure context checks inside every method of the
USB object this change removes it from the Navigator object when not in
a secure context. This is equivalent to adding the [SecureContext]
extended attribute to the NavigatorUSB interface but the WebIDL code
generator doesn't support mixing it with [OriginTrialEnabled]. Instead
the secure context check is added to the hand-written Origin Trial code
in ConditionalFeaturesForModules.cpp.

BUG=691031
==========

[commit-bot: I haz the power, 2017-02-17 23:17:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 01:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:21:35]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Mike West, 2017-02-18 11:19:49]

It surprises me that we can't set both OriginTrial and SecureContext. :/ Mind
filing a bug?

LGTM otherwise.

[Reilly Grant (use Gerrit), 2017-02-18 19:23:54]

On 2017/02/18 11:19:49, Mike West (sloooooow) wrote:
> It surprises me that we can't set both OriginTrial and SecureContext. :/ Mind
> filing a bug?

Will do.

[Reilly Grant (use Gerrit), 2017-02-18 19:23:54]

On 2017/02/18 11:19:49, Mike West (sloooooow) wrote:
> It surprises me that we can't set both OriginTrial and SecureContext. :/ Mind
> filing a bug?

Will do.

[Reilly Grant (use Gerrit), 2017-02-22 18:55:26]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:56:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chasej, 2017-02-22 19:34:18]

chasej@chromium.org changed reviewers:
+ chasej@chromium.org

[chasej, 2017-02-22 19:34:18]

Drive-by (and late) comments on the changes to
ConditionalFeaturesForModules.

In short, the changes there don't hurt anything, but are unnecessary.

https://codereview.chromium.org/2698083008/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
(right):

https://codereview.chromium.org/2698083008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp:60:
executionContext->isSecureContext()) {
The check for secure context is redundant. Origin trials are already
limited to secure contexts. So, the OriginTrials::webUSBEnabled()
method will return false if it is not a secure context.

https://codereview.chromium.org/2698083008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp:76:
executionContext->isSecureContext()) {
Ditto.

[Reilly Grant (use Gerrit), 2017-02-22 19:59:39]

On 2017/02/22 19:34:18, chasej wrote:
> Drive-by (and late) comments on the changes to
> ConditionalFeaturesForModules.
> 
> In short, the changes there don't hurt anything, but are unnecessary.
> 
>
https://codereview.chromium.org/2698083008/diff/20001/third_party/WebKit/Sour...
> File
>
third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
> (right):
> 
>
https://codereview.chromium.org/2698083008/diff/20001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp:60:
> executionContext->isSecureContext()) {
> The check for secure context is redundant. Origin trials are already
> limited to secure contexts. So, the OriginTrials::webUSBEnabled()
> method will return false if it is not a secure context.
> 
>
https://codereview.chromium.org/2698083008/diff/20001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp:76:
> executionContext->isSecureContext()) {
> Ditto.

The included LayoutTests fail if this check isn't present. Maybe the issue is
that when --enable-experimental-web-platform-features is enabled for the tests
it disables the secure context check.

[commit-bot: I haz the power, 2017-02-22 23:05:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487789726271960,
"parent_rev": "40451d83251c67992edcdf2437fde9b88e71bca2", "commit_rev":
"9a05ae84e268e91f39a684bc565484110c16da1b"}

[commit-bot: I haz the power, 2017-02-22 23:06:45]

Description was changed from

==========
Make the navigator.usb attribute accessible only in secure contexts.

Instead of performing secure context checks inside every method of the
USB object this change removes it from the Navigator object when not in
a secure context. This is equivalent to adding the [SecureContext]
extended attribute to the NavigatorUSB interface but the WebIDL code
generator doesn't support mixing it with [OriginTrialEnabled]. Instead
the secure context check is added to the hand-written Origin Trial code
in ConditionalFeaturesForModules.cpp.

BUG=691031
==========

to

==========
Make the navigator.usb attribute accessible only in secure contexts.

Instead of performing secure context checks inside every method of the
USB object this change removes it from the Navigator object when not in
a secure context. This is equivalent to adding the [SecureContext]
extended attribute to the NavigatorUSB interface but the WebIDL code
generator doesn't support mixing it with [OriginTrialEnabled]. Instead
the secure context check is added to the hand-written Origin Trial code
in ConditionalFeaturesForModules.cpp.

BUG=691031

Review-Url: https://codereview.chromium.org/2698083008
Cr-Commit-Position: refs/heads/master@{#452256}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a05ae84e268e91f39a684bc5654...
==========

[commit-bot: I haz the power, 2017-02-22 23:06:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a05ae84e268e91f39a684bc5654...

[Matt Giuca, 2017-03-29 04:46:35]

mgiuca@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2017-03-29 04:46:36]

For those playing at home, the bug filed for SecureContext incompatibility is:
https://bugs.chromium.org/p/chromium/issues/detail?id=695123

[Matt Giuca, 2017-03-29 04:46:45]

Description was changed from

==========
Make the navigator.usb attribute accessible only in secure contexts.

Instead of performing secure context checks inside every method of the
USB object this change removes it from the Navigator object when not in
a secure context. This is equivalent to adding the [SecureContext]
extended attribute to the NavigatorUSB interface but the WebIDL code
generator doesn't support mixing it with [OriginTrialEnabled]. Instead
the secure context check is added to the hand-written Origin Trial code
in ConditionalFeaturesForModules.cpp.

BUG=691031

Review-Url: https://codereview.chromium.org/2698083008
Cr-Commit-Position: refs/heads/master@{#452256}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a05ae84e268e91f39a684bc5654...
==========

to

==========
Make the navigator.usb attribute accessible only in secure contexts.

Instead of performing secure context checks inside every method of the
USB object this change removes it from the Navigator object when not in
a secure context. This is equivalent to adding the [SecureContext]
extended attribute to the NavigatorUSB interface but the WebIDL code
generator doesn't support mixing it with [OriginTrialEnabled]. Instead
the secure context check is added to the hand-written Origin Trial code
in ConditionalFeaturesForModules.cpp.

BUG=691031

Review-Url: https://codereview.chromium.org/2698083008
Cr-Commit-Position: refs/heads/master@{#452256}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a05ae84e268e91f39a684bc5654...
==========

[Matt Giuca, 2017-03-29 04:46:45]

mgiuca@chromium.org changed reviewers:
- mgiuca@chromium.org