Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(175)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/usb/insecure-context.html
Issue
2698083008
:
Make the navigator.usb attribute accessible only in secure contexts. (Closed)
Patch Set: Moved [NoInterfaceObject] change to a separate patch.
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/http/tests/usb/insecure-context.html
third_party/WebKit/LayoutTests/http/tests/usb/secure-context.html
third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl
third_party/WebKit/Source/modules/webusb/USB.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/http/tests/usb/secure-context.html »
('j') |
third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<script src="/resources/testharness.js"></script>
3
<script src="/resources/testharnessreport.js"></script>
4
<script src="/resources/get-host-info.js"></script>
5
<script>
6
'use strict';
7
8
if (window.location.origin != get_host_info().UNAUTHENTICATED_ORIGIN) {
9
window.location = get_host_info().UNAUTHENTICATED_ORIGIN +
10
window.location.pathname;
11
} else {
12
test(t => {
13
assert_false(window.isSecureContext);
14
assert_true(navigator.usb == undefined);
15
}, 'navigator.usb is not present in an insecure context');
16
}
17
</script>
OLD
NEW
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/http/tests/usb/secure-context.html »
('j') |
third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp »
('J')
Issue 2698083008: Make the navigator.usb attribute accessible only in secure contexts. (Closed)
Created 3 years, 10 months ago by Reilly Grant (use Gerrit)
Modified 3 years, 8 months ago
Reviewers: Mike West, chasej
Base URL:
Comments: 2
This is Rietveld
408576698