third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl - Issue 2698083008: Make the navigator.usb attribute accessible only in secure contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl

Issue 2698083008: Make the navigator.usb attribute accessible only in secure contexts. (Closed)

Patch Set: Moved [NoInterfaceObject] change to a separate patch. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl

diff --git a/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl b/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl

index 581358ffc80cd71d92a87c332e4e7d72469fc5be..e9a852278203a5cfc2499e315e15ad201a45f1c5 100644

--- a/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl

+++ b/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl

@@ -4,6 +4,9 @@

// https://wicg.github.io/webusb/#enumeration

+// The [SecureContext] and [OriginTrialEnabled] extended attributes don't mix.

+// Once this is out of origin trial and the secure context logic is removed from

+// ConditionalFeaturesForModules.cpp add [SecureContext] here.

partial interface Navigator {

[OriginTrialEnabled=WebUSB] readonly attribute USB usb;

};