Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl

Issue 2698083008: Make the navigator.usb attribute accessible only in secure contexts. (Closed)
Patch Set: Moved [NoInterfaceObject] change to a separate patch. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl
diff --git a/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl b/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl
index 581358ffc80cd71d92a87c332e4e7d72469fc5be..e9a852278203a5cfc2499e315e15ad201a45f1c5 100644
--- a/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl
+++ b/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl
@@ -4,6 +4,9 @@
// https://wicg.github.io/webusb/#enumeration
+// The [SecureContext] and [OriginTrialEnabled] extended attributes don't mix.
+// Once this is out of origin trial and the secure context logic is removed from
+// ConditionalFeaturesForModules.cpp add [SecureContext] here.
partial interface Navigator {
[OriginTrialEnabled=WebUSB] readonly attribute USB usb;
};

Powered by Google App Engine
This is Rietveld 408576698