Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2697723003: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Created:
3 years, 10 months ago by riju_
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, awdf+watch_chromium.org, tzik, Peter Beverloo, nhiroki, blink-reviews, kinuko+watch, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] in Notification, Blob, Fileapi BUG=670618 Review-Url: https://codereview.chromium.org/2697723003 Cr-Commit-Position: refs/heads/master@{#455443} Committed: https://chromium.googlesource.com/chromium/src/+/f6b290a86838216ae5d9028fac36b11bb0c9614a

Patch Set 1 #

Patch Set 2 : Window.{focus|close} both take ExecutionContext. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M third_party/WebKit/Source/core/fileapi/Blob.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (22 generated)
riju_
@haraken: PTAL. CallWith=ExecutionContext still exists for -> 1. Window.focus() : reason , content browser tests ...
3 years, 9 months ago (2017-03-08 13:39:09 UTC) #20
haraken
LGTM
3 years, 9 months ago (2017-03-08 13:45:31 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697723003/40001
3 years, 9 months ago (2017-03-08 13:46:54 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 13:51:27 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f6b290a86838216ae5d9028fac36...

Powered by Google App Engine
This is Rietveld 408576698