third_party/WebKit/Source/modules/notifications/Notification.h - Issue 2697723003: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 2697723003: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Patch Set: Window.{focus|close} both take ExecutionContext. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/notifications/Notification.h

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h

index aa588607d5d0aef76c04cd82af99c054b725e9fb..a0d5065910d16bf1b6f9cde3dd3e306602ff3b25 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.h

+++ b/third_party/WebKit/Source/modules/notifications/Notification.h

@@ -113,7 +113,7 @@ class MODULES_EXPORT Notification final

Vector<v8::Local<v8::Value>> actions(ScriptState*) const;

static String permissionString(mojom::blink::PermissionStatus);

- static String permission(ExecutionContext*);

+ static String permission(ScriptState*);

static ScriptPromise requestPermission(ScriptState*,

NotificationPermissionCallback*);