third_party/WebKit/Source/modules/notifications/Notification.cpp - Issue 2697723003: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 2697723003: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Patch Set: Window.{focus|close} both take ExecutionContext. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/notifications/Notification.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.cpp b/third_party/WebKit/Source/modules/notifications/Notification.cpp

index 0486b73f9ec0582c43109224ab8e45479a510b45..2fa651c19219b64a8840579b396e4d0dbc1bd183 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.cpp

+++ b/third_party/WebKit/Source/modules/notifications/Notification.cpp

@@ -353,7 +353,8 @@ String Notification::permissionString(

return "denied";

}

-String Notification::permission(ExecutionContext* context) {

+String Notification::permission(ScriptState* scriptState) {

+ ExecutionContext* context = scriptState->getExecutionContext();

return permissionString(

NotificationManager::from(context)->permissionStatus(context));

}