DevTools: "Delete File" in navigator should actually delete a file

DevTools: "Delete File" in navigator should actually delete a file

The IsolatedFileSystem failed to delete a file since it expects a relative
URL to be passed in.

BUG=693258
R=dgozman, pfeldman

Review-Url: https://codereview.chromium.org/2697403003
Cr-Commit-Position: refs/heads/master@{#451243}
Committed: https://chromium.googlesource.com/chromium/src/+/3bdfccc8b18cf18642fc48056a7a58d07f01265a

[lushnikov, 2017-02-16 23:48:43]

please, tkae a look

[lushnikov, 2017-02-16 23:48:50]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 23:50:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-02-17 01:13:12]

Let's add a test with mock file system - should be pretty straightforward.

https://codereview.chromium.org/2697403003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js
(right):

https://codereview.chromium.org/2697403003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js:547:
deleteFile(path) {
Let's pass the UISourceCode here instead.

https://codereview.chromium.org/2697403003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js:551:
var relativePath =
Persistence.FileSystemWorkspaceBinding.relativePath(uiSourceCode).join('/');
this._filePathForUISourceCode

[lushnikov, 2017-02-17 01:57:47]

all done, please tkae another look

https://codereview.chromium.org/2697403003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js
(right):

https://codereview.chromium.org/2697403003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js:547:
deleteFile(path) {
On 2017/02/17 01:13:12, dgozman wrote:
> Let's pass the UISourceCode here instead.

Done.

https://codereview.chromium.org/2697403003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js:551:
var relativePath =
Persistence.FileSystemWorkspaceBinding.relativePath(uiSourceCode).join('/');
On 2017/02/17 01:13:12, dgozman wrote:
> this._filePathForUISourceCode

Done.

[lushnikov, 2017-02-17 01:58:36]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 02:00:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-02-17 02:42:21]

lgtm

[commit-bot: I haz the power, 2017-02-17 04:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:04:19]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[lushnikov, 2017-02-17 04:05:20]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:06:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 06:20:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487304320554230,
"parent_rev": "7c8f809603d5e4c7eda82658f5399d8ccc24c3fc", "commit_rev":
"3bdfccc8b18cf18642fc48056a7a58d07f01265a"}

[commit-bot: I haz the power, 2017-02-17 06:20:55]

Description was changed from

==========
DevTools: "Delete File" in navigator should actually delete a file

The IsolatedFileSystem failed to delete a file since it expects a relative
URL to be passed in.

BUG=693258
R=dgozman, pfeldman
==========

to

==========
DevTools: "Delete File" in navigator should actually delete a file

The IsolatedFileSystem failed to delete a file since it expects a relative
URL to be passed in.

BUG=693258
R=dgozman, pfeldman

Review-Url: https://codereview.chromium.org/2697403003
Cr-Commit-Position: refs/heads/master@{#451243}
Committed:
https://chromium.googlesource.com/chromium/src/+/3bdfccc8b18cf18642fc48056a7a...
==========

[commit-bot: I haz the power, 2017-02-17 06:20:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3bdfccc8b18cf18642fc48056a7a...