Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

Issue 2697403003: DevTools: "Delete File" in navigator should actually delete a file (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js b/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
index 38d66abb22fabbfdd32e2de08207fe8a9cdb98f2..ca8b6ca1e1208b4c56cc6a066c2f3dd6270ed696 100644
--- a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
@@ -121,12 +121,9 @@ Snippets.ScriptSnippetModel = class extends Common.Object {
}
/**
- * @param {string} url
+ * @param {!Workspace.UISourceCode} uiSourceCode
*/
- deleteScriptSnippet(url) {
- var uiSourceCode = this._project.uiSourceCodeForURL(url);
- if (!uiSourceCode)
- return;
+ deleteScriptSnippet(uiSourceCode) {
var snippetId = this._snippetIdForUISourceCode.get(uiSourceCode) || '';
var snippet = this._snippetStorage.snippetForId(snippetId);
if (!snippet)
@@ -612,10 +609,10 @@ Snippets.SnippetsProject = class extends Bindings.ContentProviderBasedProject {
/**
* @override
- * @param {string} url
+ * @param {!Workspace.UISourceCode} uiSourceCode
*/
- deleteFile(url) {
- this._model.deleteScriptSnippet(url);
+ deleteFile(uiSourceCode) {
+ this._model.deleteScriptSnippet(uiSourceCode);
}
};

Powered by Google App Engine
This is Rietveld 408576698