third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js - Issue 2697403003: DevTools: "Delete File" in navigator should actually delete a file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js

Issue 2697403003: DevTools: "Delete File" in navigator should actually delete a file (Closed)

Patch Set: address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js ('k') | third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js

diff --git a/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js

index fec928ab97abeb60429ceea063a348dcfe7358be..22a2ec401720fb389b39ab2425a5b015d2cdd2ad 100644

--- a/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js

+++ b/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js

@@ -542,11 +542,12 @@ Persistence.FileSystemWorkspaceBinding.FileSystem = class extends Workspace.Proj

/**

* @override

- * @param {string} path

+ * @param {!Workspace.UISourceCode} uiSourceCode

- deleteFile(path) {

- this._fileSystem.deleteFile(path);

- this.removeUISourceCode(path);

+ deleteFile(uiSourceCode) {

+ var relativePath = this._filePathForUISourceCode(uiSourceCode);

+ this._fileSystem.deleteFile(relativePath);

+ this.removeUISourceCode(uiSourceCode.url());

}

/**