MD Settings: Unify multiple copies of the "edit" string to a single IDS_SETTINGS_EDIT.

MD Settings: Unify multiple copies of the "edit" string to a single IDS_SETTINGS_EDIT.

BUG=657639
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2697223004
Cr-Commit-Position: refs/heads/master@{#451202}
Committed: https://chromium.googlesource.com/chromium/src/+/9a870cddc366197ab52a0c8340e2941e3bacabcd

[dpapad, 2017-02-17 00:02:43]

Description was changed from

==========
MD Settings: Unify multiple copies of the "edit" string to a single
IDS_SETTINGS_EDIT.

BUG=657639
==========

to

==========
MD Settings: Unify multiple copies of the "edit" string to a single
IDS_SETTINGS_EDIT.

BUG=657639
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-17 00:03:21]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 00:04:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-17 00:06:44]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-02-17 00:06:44]

I was about to add yet another string for the "edit" action in the exceptions
action menu. I believe combining them to a single one is fine. We can spawn
different ones if any localization bugs show up.

FWIW, having a generic EDIT string has a precedent, see
https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?type=....
Unfortunately I could not use that one directly because it has an ampersand in
front of it (did not understand why it has it either).

[Dan Beam, 2017-02-17 00:55:02]

lgtm

[dpapad, 2017-02-17 01:03:16]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2017-02-17 01:03:18]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-02-17 01:05:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 03:30:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487293398337330, "parent_rev":
"268530902f87bec877486fe91526869b6f3aea38", "commit_rev":
"9a870cddc366197ab52a0c8340e2941e3bacabcd"}

[commit-bot: I haz the power, 2017-02-17 03:31:01]

Description was changed from

==========
MD Settings: Unify multiple copies of the "edit" string to a single
IDS_SETTINGS_EDIT.

BUG=657639
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Unify multiple copies of the "edit" string to a single
IDS_SETTINGS_EDIT.

BUG=657639
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2697223004
Cr-Commit-Position: refs/heads/master@{#451202}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a870cddc366197ab52a0c8340e2...
==========

[commit-bot: I haz the power, 2017-02-17 03:31:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a870cddc366197ab52a0c8340e2...