Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2697223004: MD Settings: Unify multiple copies of the "edit" string to a single IDS_SETTINGS_EDIT. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h" 5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/i18n/number_formatting.h" 10 #include "base/i18n/number_formatting.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 {"add", IDS_ADD}, 71 {"add", IDS_ADD},
72 {"advancedPageTitle", IDS_SETTINGS_ADVANCED}, 72 {"advancedPageTitle", IDS_SETTINGS_ADVANCED},
73 {"back", IDS_ACCNAME_BACK}, 73 {"back", IDS_ACCNAME_BACK},
74 {"basicPageTitle", IDS_SETTINGS_BASIC}, 74 {"basicPageTitle", IDS_SETTINGS_BASIC},
75 {"cancel", IDS_CANCEL}, 75 {"cancel", IDS_CANCEL},
76 {"close", IDS_CLOSE}, 76 {"close", IDS_CLOSE},
77 {"confirm", IDS_CONFIRM}, 77 {"confirm", IDS_CONFIRM},
78 {"controlledByExtension", IDS_SETTINGS_CONTROLLED_BY_EXTENSION}, 78 {"controlledByExtension", IDS_SETTINGS_CONTROLLED_BY_EXTENSION},
79 {"disable", IDS_DISABLE}, 79 {"disable", IDS_DISABLE},
80 {"done", IDS_DONE}, 80 {"done", IDS_DONE},
81 {"edit", IDS_SETTINGS_EDIT},
81 {"learnMore", IDS_LEARN_MORE}, 82 {"learnMore", IDS_LEARN_MORE},
82 {"menuButtonLabel", IDS_SETTINGS_MENU_BUTTON_LABEL}, 83 {"menuButtonLabel", IDS_SETTINGS_MENU_BUTTON_LABEL},
83 {"ok", IDS_OK}, 84 {"ok", IDS_OK},
84 {"restart", IDS_SETTINGS_RESTART}, 85 {"restart", IDS_SETTINGS_RESTART},
85 {"save", IDS_SAVE}, 86 {"save", IDS_SAVE},
86 {"settings", IDS_SETTINGS_SETTINGS}, 87 {"settings", IDS_SETTINGS_SETTINGS},
87 }; 88 };
88 AddLocalizedStringsBulk(html_source, localized_strings, 89 AddLocalizedStringsBulk(html_source, localized_strings,
89 arraysize(localized_strings)); 90 arraysize(localized_strings));
90 91
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 {"certificateManagerServersDescription", 408 {"certificateManagerServersDescription",
408 IDS_SETTINGS_CERTIFICATE_MANAGER_SERVERS_DESCRIPTION}, 409 IDS_SETTINGS_CERTIFICATE_MANAGER_SERVERS_DESCRIPTION},
409 {"certificateManagerAuthorities", 410 {"certificateManagerAuthorities",
410 IDS_SETTINGS_CERTIFICATE_MANAGER_AUTHORITIES}, 411 IDS_SETTINGS_CERTIFICATE_MANAGER_AUTHORITIES},
411 {"certificateManagerAuthoritiesDescription", 412 {"certificateManagerAuthoritiesDescription",
412 IDS_SETTINGS_CERTIFICATE_MANAGER_AUTHORITIES_DESCRIPTION}, 413 IDS_SETTINGS_CERTIFICATE_MANAGER_AUTHORITIES_DESCRIPTION},
413 {"certificateManagerOthers", IDS_SETTINGS_CERTIFICATE_MANAGER_OTHERS}, 414 {"certificateManagerOthers", IDS_SETTINGS_CERTIFICATE_MANAGER_OTHERS},
414 {"certificateManagerOthersDescription", 415 {"certificateManagerOthersDescription",
415 IDS_SETTINGS_CERTIFICATE_MANAGER_OTHERS_DESCRIPTION}, 416 IDS_SETTINGS_CERTIFICATE_MANAGER_OTHERS_DESCRIPTION},
416 {"certificateManagerView", IDS_SETTINGS_CERTIFICATE_MANAGER_VIEW}, 417 {"certificateManagerView", IDS_SETTINGS_CERTIFICATE_MANAGER_VIEW},
417 {"certificateManagerEdit", IDS_SETTINGS_CERTIFICATE_MANAGER_EDIT},
418 {"certificateManagerImport", IDS_SETTINGS_CERTIFICATE_MANAGER_IMPORT}, 418 {"certificateManagerImport", IDS_SETTINGS_CERTIFICATE_MANAGER_IMPORT},
419 {"certificateManagerImportAndBind", 419 {"certificateManagerImportAndBind",
420 IDS_SETTINGS_CERTIFICATE_MANAGER_IMPORT_AND_BIND}, 420 IDS_SETTINGS_CERTIFICATE_MANAGER_IMPORT_AND_BIND},
421 {"certificateManagerExport", IDS_SETTINGS_CERTIFICATE_MANAGER_EXPORT}, 421 {"certificateManagerExport", IDS_SETTINGS_CERTIFICATE_MANAGER_EXPORT},
422 {"certificateManagerDelete", IDS_SETTINGS_CERTIFICATE_MANAGER_DELETE}, 422 {"certificateManagerDelete", IDS_SETTINGS_CERTIFICATE_MANAGER_DELETE},
423 {"certificateManagerDone", IDS_SETTINGS_CERTIFICATE_MANAGER_DONE}, 423 {"certificateManagerDone", IDS_SETTINGS_CERTIFICATE_MANAGER_DONE},
424 {"certificateManagerUntrusted", 424 {"certificateManagerUntrusted",
425 IDS_SETTINGS_CERTIFICATE_MANAGER_UNTRUSTED}, 425 IDS_SETTINGS_CERTIFICATE_MANAGER_UNTRUSTED},
426 // CA trust edit dialog. 426 // CA trust edit dialog.
427 {"certificateManagerCaTrustEditDialogTitle", 427 {"certificateManagerCaTrustEditDialogTitle",
(...skipping 587 matching lines...) Expand 10 before | Expand all | Expand 10 after
1015 LocalizedString localized_strings[] = { 1015 LocalizedString localized_strings[] = {
1016 {"onStartup", IDS_SETTINGS_ON_STARTUP}, 1016 {"onStartup", IDS_SETTINGS_ON_STARTUP},
1017 {"onStartupOpenNewTab", IDS_SETTINGS_ON_STARTUP_OPEN_NEW_TAB}, 1017 {"onStartupOpenNewTab", IDS_SETTINGS_ON_STARTUP_OPEN_NEW_TAB},
1018 {"onStartupContinue", IDS_SETTINGS_ON_STARTUP_CONTINUE}, 1018 {"onStartupContinue", IDS_SETTINGS_ON_STARTUP_CONTINUE},
1019 {"onStartupOpenSpecific", IDS_SETTINGS_ON_STARTUP_OPEN_SPECIFIC}, 1019 {"onStartupOpenSpecific", IDS_SETTINGS_ON_STARTUP_OPEN_SPECIFIC},
1020 {"onStartupUseCurrent", IDS_SETTINGS_ON_STARTUP_USE_CURRENT}, 1020 {"onStartupUseCurrent", IDS_SETTINGS_ON_STARTUP_USE_CURRENT},
1021 {"onStartupAddNewPage", IDS_SETTINGS_ON_STARTUP_ADD_NEW_PAGE}, 1021 {"onStartupAddNewPage", IDS_SETTINGS_ON_STARTUP_ADD_NEW_PAGE},
1022 {"onStartupEditPage", IDS_SETTINGS_ON_STARTUP_EDIT_PAGE}, 1022 {"onStartupEditPage", IDS_SETTINGS_ON_STARTUP_EDIT_PAGE},
1023 {"onStartupSiteUrl", IDS_SETTINGS_ON_STARTUP_SITE_URL}, 1023 {"onStartupSiteUrl", IDS_SETTINGS_ON_STARTUP_SITE_URL},
1024 {"onStartupRemove", IDS_SETTINGS_ON_STARTUP_REMOVE}, 1024 {"onStartupRemove", IDS_SETTINGS_ON_STARTUP_REMOVE},
1025 {"onStartupEdit", IDS_SETTINGS_ON_STARTUP_EDIT},
1026 }; 1025 };
1027 AddLocalizedStringsBulk(html_source, localized_strings, 1026 AddLocalizedStringsBulk(html_source, localized_strings,
1028 arraysize(localized_strings)); 1027 arraysize(localized_strings));
1029 } 1028 }
1030 1029
1031 void AddPasswordsAndFormsStrings(content::WebUIDataSource* html_source) { 1030 void AddPasswordsAndFormsStrings(content::WebUIDataSource* html_source) {
1032 LocalizedString localized_strings[] = { 1031 LocalizedString localized_strings[] = {
1033 {"overflowMenu", IDS_SETTINGS_OVERFLOW_MENU}, 1032 {"overflowMenu", IDS_SETTINGS_OVERFLOW_MENU},
1034 {"passwordsAndAutofillPageTitle", 1033 {"passwordsAndAutofillPageTitle",
1035 IDS_SETTINGS_PASSWORDS_AND_AUTOFILL_PAGE_TITLE}, 1034 IDS_SETTINGS_PASSWORDS_AND_AUTOFILL_PAGE_TITLE},
1036 {"autofill", IDS_SETTINGS_AUTOFILL}, 1035 {"autofill", IDS_SETTINGS_AUTOFILL},
1037 {"googlePayments", IDS_SETTINGS_GOOGLE_PAYMENTS}, 1036 {"googlePayments", IDS_SETTINGS_GOOGLE_PAYMENTS},
1038 {"googlePaymentsCached", IDS_SETTINGS_GOOGLE_PAYMENTS_CACHED}, 1037 {"googlePaymentsCached", IDS_SETTINGS_GOOGLE_PAYMENTS_CACHED},
1039 {"addresses", IDS_SETTINGS_AUTOFILL_ADDRESSES_HEADING}, 1038 {"addresses", IDS_SETTINGS_AUTOFILL_ADDRESSES_HEADING},
1040 {"addAddressTitle", IDS_SETTINGS_AUTOFILL_ADDRESSES_ADD_TITLE}, 1039 {"addAddressTitle", IDS_SETTINGS_AUTOFILL_ADDRESSES_ADD_TITLE},
1041 {"editAddressTitle", IDS_SETTINGS_AUTOFILL_ADDRESSES_EDIT_TITLE}, 1040 {"editAddressTitle", IDS_SETTINGS_AUTOFILL_ADDRESSES_EDIT_TITLE},
1042 {"addressCountry", IDS_SETTINGS_AUTOFILL_ADDRESSES_COUNTRY}, 1041 {"addressCountry", IDS_SETTINGS_AUTOFILL_ADDRESSES_COUNTRY},
1043 {"addressPhone", IDS_SETTINGS_AUTOFILL_ADDRESSES_PHONE}, 1042 {"addressPhone", IDS_SETTINGS_AUTOFILL_ADDRESSES_PHONE},
1044 {"addressEmail", IDS_SETTINGS_AUTOFILL_ADDRESSES_EMAIL}, 1043 {"addressEmail", IDS_SETTINGS_AUTOFILL_ADDRESSES_EMAIL},
1045 {"editAddress", IDS_SETTINGS_ADDRESS_EDIT},
1046 {"removeAddress", IDS_SETTINGS_ADDRESS_REMOVE}, 1044 {"removeAddress", IDS_SETTINGS_ADDRESS_REMOVE},
1047 {"creditCards", IDS_SETTINGS_AUTOFILL_CREDIT_CARD_HEADING}, 1045 {"creditCards", IDS_SETTINGS_AUTOFILL_CREDIT_CARD_HEADING},
1048 {"editCreditCard", IDS_SETTINGS_CREDIT_CARD_EDIT},
1049 {"removeCreditCard", IDS_SETTINGS_CREDIT_CARD_REMOVE}, 1046 {"removeCreditCard", IDS_SETTINGS_CREDIT_CARD_REMOVE},
1050 {"clearCreditCard", IDS_SETTINGS_CREDIT_CARD_CLEAR}, 1047 {"clearCreditCard", IDS_SETTINGS_CREDIT_CARD_CLEAR},
1051 {"creditCardType", IDS_SETTINGS_AUTOFILL_CREDIT_CARD_TYPE_COLUMN_LABEL}, 1048 {"creditCardType", IDS_SETTINGS_AUTOFILL_CREDIT_CARD_TYPE_COLUMN_LABEL},
1052 {"creditCardExpiration", IDS_SETTINGS_CREDIT_CARD_EXPIRATION_DATE}, 1049 {"creditCardExpiration", IDS_SETTINGS_CREDIT_CARD_EXPIRATION_DATE},
1053 {"creditCardName", IDS_SETTINGS_NAME_ON_CREDIT_CARD}, 1050 {"creditCardName", IDS_SETTINGS_NAME_ON_CREDIT_CARD},
1054 {"creditCardNumber", IDS_SETTINGS_CREDIT_CARD_NUMBER}, 1051 {"creditCardNumber", IDS_SETTINGS_CREDIT_CARD_NUMBER},
1055 {"creditCardExpirationMonth", IDS_SETTINGS_CREDIT_CARD_EXPIRATION_MONTH}, 1052 {"creditCardExpirationMonth", IDS_SETTINGS_CREDIT_CARD_EXPIRATION_MONTH},
1056 {"creditCardExpirationYear", IDS_SETTINGS_CREDIT_CARD_EXPIRATION_YEAR}, 1053 {"creditCardExpirationYear", IDS_SETTINGS_CREDIT_CARD_EXPIRATION_YEAR},
1057 {"creditCardExpired", IDS_SETTINGS_CREDIT_CARD_EXPIRED}, 1054 {"creditCardExpired", IDS_SETTINGS_CREDIT_CARD_EXPIRED},
1058 {"editCreditCardTitle", IDS_SETTINGS_EDIT_CREDIT_CARD_TITLE}, 1055 {"editCreditCardTitle", IDS_SETTINGS_EDIT_CREDIT_CARD_TITLE},
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
1514 {"searchEnginesOther", IDS_SETTINGS_SEARCH_ENGINES_OTHER_ENGINES}, 1511 {"searchEnginesOther", IDS_SETTINGS_SEARCH_ENGINES_OTHER_ENGINES},
1515 {"searchEnginesNoOtherEngines", 1512 {"searchEnginesNoOtherEngines",
1516 IDS_SETTINGS_SEARCH_ENGINES_NO_OTHER_ENGINES}, 1513 IDS_SETTINGS_SEARCH_ENGINES_NO_OTHER_ENGINES},
1517 {"searchEnginesExtension", IDS_SETTINGS_SEARCH_ENGINES_EXTENSION_ENGINES}, 1514 {"searchEnginesExtension", IDS_SETTINGS_SEARCH_ENGINES_EXTENSION_ENGINES},
1518 {"searchEnginesSearchEngine", IDS_SETTINGS_SEARCH_ENGINES_SEARCH_ENGINE}, 1515 {"searchEnginesSearchEngine", IDS_SETTINGS_SEARCH_ENGINES_SEARCH_ENGINE},
1519 {"searchEnginesKeyword", IDS_SETTINGS_SEARCH_ENGINES_KEYWORD}, 1516 {"searchEnginesKeyword", IDS_SETTINGS_SEARCH_ENGINES_KEYWORD},
1520 {"searchEnginesQueryURL", IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL}, 1517 {"searchEnginesQueryURL", IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL},
1521 {"searchEnginesQueryURLExplanation", 1518 {"searchEnginesQueryURLExplanation",
1522 IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL_EXPLANATION}, 1519 IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL_EXPLANATION},
1523 {"searchEnginesMakeDefault", IDS_SETTINGS_SEARCH_ENGINES_MAKE_DEFAULT}, 1520 {"searchEnginesMakeDefault", IDS_SETTINGS_SEARCH_ENGINES_MAKE_DEFAULT},
1524 {"searchEnginesEdit", IDS_SETTINGS_SEARCH_ENGINES_EDIT},
1525 {"searchEnginesRemoveFromList", 1521 {"searchEnginesRemoveFromList",
1526 IDS_SETTINGS_SEARCH_ENGINES_REMOVE_FROM_LIST}, 1522 IDS_SETTINGS_SEARCH_ENGINES_REMOVE_FROM_LIST},
1527 {"searchEnginesManageExtension", 1523 {"searchEnginesManageExtension",
1528 IDS_SETTINGS_SEARCH_ENGINES_MANAGE_EXTENSION}, 1524 IDS_SETTINGS_SEARCH_ENGINES_MANAGE_EXTENSION},
1529 }; 1525 };
1530 AddLocalizedStringsBulk(html_source, localized_strings, 1526 AddLocalizedStringsBulk(html_source, localized_strings,
1531 arraysize(localized_strings)); 1527 arraysize(localized_strings));
1532 } 1528 }
1533 1529
1534 void AddSiteSettingsStrings(content::WebUIDataSource* html_source, 1530 void AddSiteSettingsStrings(content::WebUIDataSource* html_source,
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
1945 1941
1946 #if defined(OS_CHROMEOS) 1942 #if defined(OS_CHROMEOS)
1947 chromeos::network_element::AddLocalizedStrings(html_source); 1943 chromeos::network_element::AddLocalizedStrings(html_source);
1948 #endif 1944 #endif
1949 policy_indicator::AddLocalizedStrings(html_source); 1945 policy_indicator::AddLocalizedStrings(html_source);
1950 1946
1951 html_source->SetJsonPath(kLocalizedStringsFile); 1947 html_source->SetJsonPath(kLocalizedStringsFile);
1952 } 1948 }
1953 1949
1954 } // namespace settings 1950 } // namespace settings
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698