Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5310)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2697223004: MD Settings: Unify multiple copies of the "edit" string to a single IDS_SETTINGS_EDIT. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index 9f4fc0d60a483c1ef7e933e8ca5e639c32ff5d6b..7205b46e874cbbd9121e52c970313a2e17f2d0b3 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -78,6 +78,7 @@ void AddCommonStrings(content::WebUIDataSource* html_source, Profile* profile) {
{"controlledByExtension", IDS_SETTINGS_CONTROLLED_BY_EXTENSION},
{"disable", IDS_DISABLE},
{"done", IDS_DONE},
+ {"edit", IDS_SETTINGS_EDIT},
{"learnMore", IDS_LEARN_MORE},
{"menuButtonLabel", IDS_SETTINGS_MENU_BUTTON_LABEL},
{"ok", IDS_OK},
@@ -414,7 +415,6 @@ void AddCertificateManagerStrings(content::WebUIDataSource* html_source) {
{"certificateManagerOthersDescription",
IDS_SETTINGS_CERTIFICATE_MANAGER_OTHERS_DESCRIPTION},
{"certificateManagerView", IDS_SETTINGS_CERTIFICATE_MANAGER_VIEW},
- {"certificateManagerEdit", IDS_SETTINGS_CERTIFICATE_MANAGER_EDIT},
{"certificateManagerImport", IDS_SETTINGS_CERTIFICATE_MANAGER_IMPORT},
{"certificateManagerImportAndBind",
IDS_SETTINGS_CERTIFICATE_MANAGER_IMPORT_AND_BIND},
@@ -1022,7 +1022,6 @@ void AddOnStartupStrings(content::WebUIDataSource* html_source) {
{"onStartupEditPage", IDS_SETTINGS_ON_STARTUP_EDIT_PAGE},
{"onStartupSiteUrl", IDS_SETTINGS_ON_STARTUP_SITE_URL},
{"onStartupRemove", IDS_SETTINGS_ON_STARTUP_REMOVE},
- {"onStartupEdit", IDS_SETTINGS_ON_STARTUP_EDIT},
};
AddLocalizedStringsBulk(html_source, localized_strings,
arraysize(localized_strings));
@@ -1042,10 +1041,8 @@ void AddPasswordsAndFormsStrings(content::WebUIDataSource* html_source) {
{"addressCountry", IDS_SETTINGS_AUTOFILL_ADDRESSES_COUNTRY},
{"addressPhone", IDS_SETTINGS_AUTOFILL_ADDRESSES_PHONE},
{"addressEmail", IDS_SETTINGS_AUTOFILL_ADDRESSES_EMAIL},
- {"editAddress", IDS_SETTINGS_ADDRESS_EDIT},
{"removeAddress", IDS_SETTINGS_ADDRESS_REMOVE},
{"creditCards", IDS_SETTINGS_AUTOFILL_CREDIT_CARD_HEADING},
- {"editCreditCard", IDS_SETTINGS_CREDIT_CARD_EDIT},
{"removeCreditCard", IDS_SETTINGS_CREDIT_CARD_REMOVE},
{"clearCreditCard", IDS_SETTINGS_CREDIT_CARD_CLEAR},
{"creditCardType", IDS_SETTINGS_AUTOFILL_CREDIT_CARD_TYPE_COLUMN_LABEL},
@@ -1521,7 +1518,6 @@ void AddSearchEnginesStrings(content::WebUIDataSource* html_source) {
{"searchEnginesQueryURLExplanation",
IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL_EXPLANATION},
{"searchEnginesMakeDefault", IDS_SETTINGS_SEARCH_ENGINES_MAKE_DEFAULT},
- {"searchEnginesEdit", IDS_SETTINGS_SEARCH_ENGINES_EDIT},
{"searchEnginesRemoveFromList",
IDS_SETTINGS_SEARCH_ENGINES_REMOVE_FROM_LIST},
{"searchEnginesManageExtension",
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698