Move some Physical Web strings to new location and add OWNERS

Add OWNERS for Physical Web strings and move strings.

We are changing from ListUrlsActivity to WebUI. Move strings to
physical_web_ui_strings.grdp so they can be accessed in WebUI.

BUG=692789
Review-Url: https://codereview.chromium.org/2697193006
Cr-Commit-Position: refs/heads/master@{#452159}
Committed: https://chromium.googlesource.com/chromium/src/+/f6abba5e558aed73885e07c3ac1abdc4595ec764

[Ran, 2017-02-16 18:35:14]

Description was changed from

==========
adding new string for scanning and no result notification

BUG=692789
==========

to

==========
adding new string for scanning and empty result notification

BUG=692789
==========

[Ran, 2017-02-16 18:36:10]

ranj@chromium.org changed reviewers:
+ jochen@chromium.org, mattreynolds@chromium.org, mmocny@chromium.org

[Ran, 2017-02-16 18:48:36]

Description was changed from

==========
adding new string for scanning and empty result notification

BUG=692789
==========

to

==========
Duplicate strings for scanning and empty result notification here so that they
can be accessed in webui

BUG=692789
==========

[mattreynolds, 2017-02-16 20:04:41]

lgtm

https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
File components/physical_web_ui_strings.grdp (right):

https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
components/physical_web_ui_strings.grdp:6: <!-- These two messages are
duplicated in android/java/strings/android_chrome_strings.grd -->
Is this comment still necessary? I couldn't find the strings in
android_chrome_strings.grd, maybe they've been removed already?

[Ran, 2017-02-16 20:08:53]

https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
File components/physical_web_ui_strings.grdp (right):

https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
components/physical_web_ui_strings.grdp:6: <!-- These two messages are
duplicated in android/java/strings/android_chrome_strings.grd -->
On 2017/02/16 20:04:41, mattreynolds wrote:
> Is this comment still necessary? I couldn't find the strings in
> android_chrome_strings.grd, maybe they've been removed already?

They have same value, but the ids are different.
https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro...

[mattreynolds, 2017-02-16 20:14:42]

https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
File components/physical_web_ui_strings.grdp (right):

https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
components/physical_web_ui_strings.grdp:6: <!-- These two messages are
duplicated in android/java/strings/android_chrome_strings.grd -->
On 2017/02/16 20:08:52, Ran wrote:
> On 2017/02/16 20:04:41, mattreynolds wrote:
> > Is this comment still necessary? I couldn't find the strings in
> > android_chrome_strings.grd, maybe they've been removed already?
> 
> They have same value, but the ids are different.
>
https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro...

Ah, looks like they are unused. Could you remove them?

I think we can remove everything from IDS_PHYSICAL_WEB_OPTIN_TITLE to
IDS_PHYSICAL_WEB_LAUNCH_BUTTON.  They were used by Physical Web notifications,
the opt-in interstitial, and the old list view activity which have all been
removed.

[Ran, 2017-02-16 20:23:34]

On 2017/02/16 20:14:42, mattreynolds wrote:
>
https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
> File components/physical_web_ui_strings.grdp (right):
> 
>
https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
> components/physical_web_ui_strings.grdp:6: <!-- These two messages are
> duplicated in android/java/strings/android_chrome_strings.grd -->
> On 2017/02/16 20:08:52, Ran wrote:
> > On 2017/02/16 20:04:41, mattreynolds wrote:
> > > Is this comment still necessary? I couldn't find the strings in
> > > android_chrome_strings.grd, maybe they've been removed already?
> > 
> > They have same value, but the ids are different.
> >
>
https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro...
> 
> Ah, looks like they are unused. Could you remove them?
> 
> I think we can remove everything from IDS_PHYSICAL_WEB_OPTIN_TITLE to
> IDS_PHYSICAL_WEB_LAUNCH_BUTTON.  They were used by Physical Web notifications,
> the opt-in interstitial, and the old list view activity which have all been
> removed.

Done.

[mmocny, 2017-02-16 20:30:32]

On 2017/02/16 20:23:34, Ran wrote:
> On 2017/02/16 20:14:42, mattreynolds wrote:
> >
>
https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
> > File components/physical_web_ui_strings.grdp (right):
> > 
> >
>
https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
> > components/physical_web_ui_strings.grdp:6: <!-- These two messages are
> > duplicated in android/java/strings/android_chrome_strings.grd -->
> > On 2017/02/16 20:08:52, Ran wrote:
> > > On 2017/02/16 20:04:41, mattreynolds wrote:
> > > > Is this comment still necessary? I couldn't find the strings in
> > > > android_chrome_strings.grd, maybe they've been removed already?
> > > 
> > > They have same value, but the ids are different.
> > >
> >
>
https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro...
> > 
> > Ah, looks like they are unused. Could you remove them?
> > 
> > I think we can remove everything from IDS_PHYSICAL_WEB_OPTIN_TITLE to
> > IDS_PHYSICAL_WEB_LAUNCH_BUTTON.  They were used by Physical Web
notifications,
> > the opt-in interstitial, and the old list view activity which have all been
> > removed.
> 
> Done.

Could we make it obvious to language translators that we already have
translations for these strings under the old names?

Not sure if we should just update this patch description?

[Ran, 2017-02-16 20:38:40]

Description was changed from

==========
Duplicate strings for scanning and empty result notification here so that they
can be accessed in webui

BUG=692789
==========

to

==========
Move string from chrome/android/java/strings/android_chrome_strings.grd to
components/physical_web_ui_strings.grdp, clean unused string in
chrome/android/java/strings/android_chrome_strings.grd

BUG=692789
==========

[Ran, 2017-02-16 20:39:49]

On 2017/02/16 20:30:32, mmocny wrote:
> On 2017/02/16 20:23:34, Ran wrote:
> > On 2017/02/16 20:14:42, mattreynolds wrote:
> > >
> >
>
https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
> > > File components/physical_web_ui_strings.grdp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2697193006/diff/20001/components/physical_web...
> > > components/physical_web_ui_strings.grdp:6: <!-- These two messages are
> > > duplicated in android/java/strings/android_chrome_strings.grd -->
> > > On 2017/02/16 20:08:52, Ran wrote:
> > > > On 2017/02/16 20:04:41, mattreynolds wrote:
> > > > > Is this comment still necessary? I couldn't find the strings in
> > > > > android_chrome_strings.grd, maybe they've been removed already?
> > > > 
> > > > They have same value, but the ids are different.
> > > >
> > >
> >
>
https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro...
> > > 
> > > Ah, looks like they are unused. Could you remove them?
> > > 
> > > I think we can remove everything from IDS_PHYSICAL_WEB_OPTIN_TITLE to
> > > IDS_PHYSICAL_WEB_LAUNCH_BUTTON.  They were used by Physical Web
> notifications,
> > > the opt-in interstitial, and the old list view activity which have all
been
> > > removed.
> > 
> > Done.
> 
> Could we make it obvious to language translators that we already have
> translations for these strings under the old names?
> 
> Not sure if we should just update this patch description?

Updated description. I don't think it matters that much as it only takes seconds
to translate a message.

[mmocny, 2017-02-16 22:08:53]

lgtm

Thanks for updating the description.

[Ran, 2017-02-16 22:28:04]

ranj@chromium.org changed reviewers:
+ cco3@chromium.org

[Ran, 2017-02-16 22:28:05]

As discuses, do the clean up in another cl.

[Ran, 2017-02-16 22:33:12]

The CQ bit was checked by ranj@chromium.org to run a CQ dry run

[cco3, 2017-02-16 22:34:43]

Commit subjects should be:
* capitalized,
* imperative, and
* limited to 50-columns.

Suggestion:
"Add strings for displaying PW scanning info"

https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
File components/physical_web_ui_strings.grdp (right):

https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
components/physical_web_ui_strings.grdp:6: <message
name="IDS_PHYSICAL_WEB_UI_EMPTY_MESSAGE" desc="The message displayed in place of
a list of nearby URLs when there are no URLs to display.">
Why are we adding strings if we aren't using them?

https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
components/physical_web_ui_strings.grdp:7: No Physical Web URLs to show
Haven't we avoided using the term "URL"?  This should be No Physical Web pages

[commit-bot: I haz the power, 2017-02-16 22:35:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cco3, 2017-02-16 22:35:47]

On 2017/02/16 22:34:43, cco3 wrote:
> Commit subjects should be:
> * capitalized,
> * imperative, and
> * limited to 50-columns.
> 
> Suggestion:
> "Add strings for displaying PW scanning info"
> 
>
https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
> File components/physical_web_ui_strings.grdp (right):
> 
>
https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
> components/physical_web_ui_strings.grdp:6: <message
> name="IDS_PHYSICAL_WEB_UI_EMPTY_MESSAGE" desc="The message displayed in place
of
> a list of nearby URLs when there are no URLs to display.">
> Why are we adding strings if we aren't using them?
> 
>
https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
> components/physical_web_ui_strings.grdp:7: No Physical Web URLs to show
> Haven't we avoided using the term "URL"?  This should be No Physical Web pages

Also, the commit message/CL description doesn't seem to match the change.

[cco3, 2017-02-16 22:37:36]

On 2017/02/16 22:35:47, cco3 wrote:
> On 2017/02/16 22:34:43, cco3 wrote:
> > Commit subjects should be:
> > * capitalized,
> > * imperative, and
> > * limited to 50-columns.
> > 
> > Suggestion:
> > "Add strings for displaying PW scanning info"
> > 
> >
>
https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
> > File components/physical_web_ui_strings.grdp (right):
> > 
> >
>
https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
> > components/physical_web_ui_strings.grdp:6: <message
> > name="IDS_PHYSICAL_WEB_UI_EMPTY_MESSAGE" desc="The message displayed in
place
> of
> > a list of nearby URLs when there are no URLs to display.">
> > Why are we adding strings if we aren't using them?
> > 
> >
>
https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
> > components/physical_web_ui_strings.grdp:7: No Physical Web URLs to show
> > Haven't we avoided using the term "URL"?  This should be No Physical Web
pages
> 
> Also, the commit message/CL description doesn't seem to match the change.

I also don't think you removed
chrome/android/java/strings/android_chrome_strings.grd as you intended.  In the
future, you should use `git mv`.  This time, you can run `git rm -f
chrome/android/java/strings/android_chrome_strings.grd"

[cco3, 2017-02-16 22:38:31]

On 2017/02/16 22:37:36, cco3 wrote:
> On 2017/02/16 22:35:47, cco3 wrote:
> > On 2017/02/16 22:34:43, cco3 wrote:
> > > Commit subjects should be:
> > > * capitalized,
> > > * imperative, and
> > > * limited to 50-columns.
> > > 
> > > Suggestion:
> > > "Add strings for displaying PW scanning info"
> > > 
> > >
> >
>
https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
> > > File components/physical_web_ui_strings.grdp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
> > > components/physical_web_ui_strings.grdp:6: <message
> > > name="IDS_PHYSICAL_WEB_UI_EMPTY_MESSAGE" desc="The message displayed in
> place
> > of
> > > a list of nearby URLs when there are no URLs to display.">
> > > Why are we adding strings if we aren't using them?
> > > 
> > >
> >
>
https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
> > > components/physical_web_ui_strings.grdp:7: No Physical Web URLs to show
> > > Haven't we avoided using the term "URL"?  This should be No Physical Web
> pages
> > 
> > Also, the commit message/CL description doesn't seem to match the change.
> 
> I also don't think you removed
> chrome/android/java/strings/android_chrome_strings.grd as you intended.  In
the
> future, you should use `git mv`.  This time, you can run `git rm -f
> chrome/android/java/strings/android_chrome_strings.grd"

Disregard that last comment.  For some reason I thought you were trying to
remove that file.

[Ran, 2017-02-16 22:45:43]

Description was changed from

==========
Move string from chrome/android/java/strings/android_chrome_strings.grd to
components/physical_web_ui_strings.grdp, clean unused string in
chrome/android/java/strings/android_chrome_strings.grd

BUG=692789
==========

to

==========
Add string for scanning page and empty result page.

BUG=692789
==========

[Ran, 2017-02-16 22:48:32]

https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
File components/physical_web_ui_strings.grdp (right):

https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
components/physical_web_ui_strings.grdp:6: <message
name="IDS_PHYSICAL_WEB_UI_EMPTY_MESSAGE" desc="The message displayed in place of
a list of nearby URLs when there are no URLs to display.">
On 2017/02/16 22:34:43, cco3 wrote:
> Why are we adding strings if we aren't using them?

I have another cl that uses this string.
https://codereview.chromium.org/2698503004/

I try to catch the feature freeze deadline, as strings require translation need
to go before it...

https://codereview.chromium.org/2697193006/diff/60001/components/physical_web...
components/physical_web_ui_strings.grdp:7: No Physical Web URLs to show
On 2017/02/16 22:34:43, cco3 wrote:
> Haven't we avoided using the term "URL"?  This should be No Physical Web pages

Done. Thanks!

[mmocny, 2017-02-17 16:01:59]

-lgtm

Ran: Somehow the description changed and CL changed significantly.

I thought the plan was to move a few strings over to this new file, without
making any modifications to the text.  Your patch #3 was almost correct but it
had deleted too many strings (some were still used!).

I still think you should move the strings which were used by the old native
listview (which was deleted) to this new strings file to be used by the new
WebUI in a separate patch.

[jochen (gone - plz use gerrit), 2017-02-20 09:49:55]

please indicate in the CL description that this is about physical web

I assume that somebody working on the physical web stuff is in an OWNERS file
for those strings? Otherwise, please add an respective entry

[Ran, 2017-02-21 16:01:31]

Description was changed from

==========
Add string for scanning page and empty result page.

BUG=692789
==========

to

==========
Move PhysicalWeb scanning and empty result notification string from
android_chrome_strings.grd to physical_web_ui_strings.grdp.


BUG=692789
==========

[Ran, 2017-02-21 16:08:51]

On 2017/02/20 09:49:55, jochen wrote:
> please indicate in the CL description that this is about physical web
> 
> I assume that somebody working on the physical web stuff is in an OWNERS file
> for those strings? Otherwise, please add an respective entry

Physical web entry is not listed in components/OWNERS. Will update OWNERS file
in separated CL.

[Ran, 2017-02-21 16:08:54]

On 2017/02/20 09:49:55, jochen wrote:
> please indicate in the CL description that this is about physical web
> 
> I assume that somebody working on the physical web stuff is in an OWNERS file
> for those strings? Otherwise, please add an respective entry

Physical web entry is not listed in components/OWNERS. Will update OWNERS file
in separated CL.

[Ran, 2017-02-21 16:09:28]

Move strings, update description.

[cco3, 2017-02-21 22:08:57]

LGTM.

FYI: Commit description bodies should be limited to 72 columns.

[cco3, 2017-02-21 22:10:02]

On 2017/02/21 22:08:57, cco3 wrote:
> LGTM.
> 
> FYI: Commit description bodies should be limited to 72 columns.

Also, the subject might be better as "Move some Physical Web strings to new
location", and then explain in the body.

[mattreynolds, 2017-02-21 22:13:07]

> I assume that somebody working on the physical web stuff is in an OWNERS file
> for those strings? Otherwise, please add an respective entry

We must have overlooked adding the OWNERS entry for these strings.

Ran, could you add this line to components/OWNERS?

per-file physical_web_ui_strings.grdp=file://components/physical_web/OWNERS

[Ran, 2017-02-21 22:25:35]

Description was changed from

==========
Move PhysicalWeb scanning and empty result notification string from
android_chrome_strings.grd to physical_web_ui_strings.grdp.


BUG=692789
==========

to

==========
We are changing from ListUrlsActivity to WebUI. Move strings to
physical_web_ui_strings.grdp so they can be accessed in wWebUIebui.
Add OWNERS for Physical Web strings.

BUG=692789
==========

[Ran, 2017-02-21 22:26:07]

Description was changed from

==========
We are changing from ListUrlsActivity to WebUI. Move strings to
physical_web_ui_strings.grdp so they can be accessed in wWebUIebui.
Add OWNERS for Physical Web strings.

BUG=692789
==========

to

==========
We are changing from ListUrlsActivity to WebUI. Move strings to
physical_web_ui_strings.grdp so they can be accessed in WebUI.
Add OWNERS for Physical Web strings.

BUG=692789
==========

[Ran, 2017-02-21 22:29:23]

Add OWNERS

[cco3, 2017-02-21 23:28:56]

On 2017/02/21 22:29:23, Ran wrote:
> Add OWNERS

LGTM

[jochen (gone - plz use gerrit), 2017-02-22 08:58:28]

lgtm

note that the CL description needs to be reformated:
http://dev.chromium.org/developers/contributing-code#TOC-Writing-change-list-...

long lines should be wrapped, and the first line should be the summary (followed
by an empty line)

[Ran, 2017-02-22 16:08:00]

Description was changed from

==========
We are changing from ListUrlsActivity to WebUI. Move strings to
physical_web_ui_strings.grdp so they can be accessed in WebUI.
Add OWNERS for Physical Web strings.

BUG=692789
==========

to

==========
Add OWNERS for Physical Web strings and move strings.

We are changing from ListUrlsActivity to WebUI. Move strings to
physical_web_ui_strings.grdp so they can be accessed in WebUI.

BUG=692789
==========

[Ran, 2017-02-22 16:08:45]

Description was changed from

==========
Add OWNERS for Physical Web strings and move strings.

We are changing from ListUrlsActivity to WebUI. Move strings to
physical_web_ui_strings.grdp so they can be accessed in WebUI.

BUG=692789
==========

to

==========
Add OWNERS for Physical Web strings and move strings.

We are changing from ListUrlsActivity to WebUI. Move strings to
physical_web_ui_strings.grdp so they can be accessed in WebUI.

BUG=692789
==========

[Ran, 2017-02-22 16:12:03]

The CQ bit was checked by ranj@chromium.org

[Ran, 2017-02-22 16:12:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattreynolds@chromium.org, mmocny@chromium.org
Link to the patchset: https://codereview.chromium.org/2697193006/#ps120001
(title: "add OWNERS")

[commit-bot: I haz the power, 2017-02-22 16:12:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 16:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 16:36:10]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Ran, 2017-02-22 17:06:04]

The CQ bit was checked by ranj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 17:06:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 17:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 17:29:22]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ran, 2017-02-22 17:46:15]

The CQ bit was checked by ranj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 17:47:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 17:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 17:57:53]

Dry run: This issue passed the CQ dry run.

[Ran, 2017-02-22 19:10:33]

The CQ bit was checked by ranj@chromium.org

[Ran, 2017-02-22 19:10:34]

The patchset sent to the CQ was uploaded after l-g-t-m from mmocny@chromium.org,
jochen@chromium.org, cco3@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2697193006/#ps160001
(title: "fix tests, restore android_chrome_strings.grd")

[commit-bot: I haz the power, 2017-02-22 19:11:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 19:15:45]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1487790633464020,
"parent_rev": "0a7bb59fff7ca4ba57577a4dcf3e013019f5794b", "commit_rev":
"f6abba5e558aed73885e07c3ac1abdc4595ec764"}

[commit-bot: I haz the power, 2017-02-22 19:16:24]

Description was changed from

==========
Add OWNERS for Physical Web strings and move strings.

We are changing from ListUrlsActivity to WebUI. Move strings to
physical_web_ui_strings.grdp so they can be accessed in WebUI.

BUG=692789
==========

to

==========
Add OWNERS for Physical Web strings and move strings.

We are changing from ListUrlsActivity to WebUI. Move strings to
physical_web_ui_strings.grdp so they can be accessed in WebUI.

BUG=692789

Review-Url: https://codereview.chromium.org/2697193006
Cr-Commit-Position: refs/heads/master@{#452159}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6abba5e558aed73885e07c3ac1a...
==========

[commit-bot: I haz the power, 2017-02-22 19:16:26]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/f6abba5e558aed73885e07c3ac1a...