components/physical_web_ui_strings.grdp - Issue 2697193006: Move some Physical Web strings to new location and add OWNERS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/physical_web_ui_strings.grdp

Issue 2697193006: Move some Physical Web strings to new location and add OWNERS (Closed)

Patch Set: update string Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <grit-part>	2 <grit-part>

3 <message name="IDS_PHYSICAL_WEB_UI_TITLE" desc="Title of a built-in page that displays a list of Physical Web URLs (URLs broadcast by nearby devices).">	3 <message name="IDS_PHYSICAL_WEB_UI_TITLE" desc="Title of a built-in page that displays a list of Physical Web URLs (URLs broadcast by nearby devices).">

4 Physical Web	4 Physical Web

5 </message>	5 </message>

	6 <!-- These two messages are duplicated in android/java/strings/android_chrome_ strings.grd -->
	mattreynolds 2017/02/16 20:04:41 Is this comment still necessary? I couldn't find t Is this comment still necessary? I couldn't find the strings in android_chrome_strings.grd, maybe they've been removed already? Ran 2017/02/16 20:08:52 They have same value, but the ids are different. h Show quoted text On 2017/02/16 20:04:41, mattreynolds wrote: > Is this comment still necessary? I couldn't find the strings in > android_chrome_strings.grd, maybe they've been removed already? They have same value, but the ids are different. https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro... mattreynolds 2017/02/16 20:14:42 Ah, looks like they are unused. Could you remove t Show quoted text On 2017/02/16 20:08:52, Ran wrote: > On 2017/02/16 20:04:41, mattreynolds wrote: > > Is this comment still necessary? I couldn't find the strings in > > android_chrome_strings.grd, maybe they've been removed already? > > They have same value, but the ids are different. > https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro... Ah, looks like they are unused. Could you remove them? I think we can remove everything from IDS_PHYSICAL_WEB_OPTIN_TITLE to IDS_PHYSICAL_WEB_LAUNCH_BUTTON. They were used by Physical Web notifications, the opt-in interstitial, and the old list view activity which have all been removed.
	7 <message name="IDS_PHYSICAL_WEB_UI_EMPTY_MESSAGE" desc="The message displayed in place of a list of nearby URLs when there are no URLs to display.">

	8 No Physical Web URLs to show

	9 </message>

	10 <message name="IDS_PHYSICAL_WEB_UI_SCANNING_MESSAGE" desc="The message display ed in place of a list of nearby URLs while still scanning for nearby URLs.">

	11 Looking for nearby Physical Web pages

	12 </message>

6 </grit-part>	13 </grit-part>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »