components/physical_web_ui_strings.grdp - Issue 2697193006: Move some Physical Web strings to new location and add OWNERS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/physical_web_ui_strings.grdp

Issue 2697193006: Move some Physical Web strings to new location and add OWNERS (Closed)

Patch Set: reset android_chrome_strings.grd Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <grit-part>	2 <grit-part>

3 <message name="IDS_PHYSICAL_WEB_UI_TITLE" desc="Title of a built-in page that displays a list of Physical Web URLs (URLs broadcast by nearby devices).">	3 <message name="IDS_PHYSICAL_WEB_UI_TITLE" desc="Title of a built-in page that displays a list of Physical Web URLs (URLs broadcast by nearby devices).">

4 Physical Web	4 Physical Web

5 </message>	5 </message>

	6 <message name="IDS_PHYSICAL_WEB_UI_EMPTY_MESSAGE" desc="The message displayed in place of a list of nearby URLs when there are no URLs to display.">
	cco3 2017/02/16 22:34:43 Why are we adding strings if we aren't using them? Why are we adding strings if we aren't using them? Ran 2017/02/16 22:48:32 I have another cl that uses this string. https://c Show quoted text On 2017/02/16 22:34:43, cco3 wrote: > Why are we adding strings if we aren't using them? I have another cl that uses this string. https://codereview.chromium.org/2698503004/ I try to catch the feature freeze deadline, as strings require translation need to go before it...
	7 No Physical Web URLs to show
	cco3 2017/02/16 22:34:43 Haven't we avoided using the term "URL"? This sho Haven't we avoided using the term "URL"? This should be No Physical Web pages Ran 2017/02/16 22:48:32 Done. Thanks! Show quoted text On 2017/02/16 22:34:43, cco3 wrote: > Haven't we avoided using the term "URL"? This should be No Physical Web pages Done. Thanks!
	8 </message>

	9 <message name="IDS_PHYSICAL_WEB_UI_SCANNING_MESSAGE" desc="The message display ed in place of a list of nearby URLs while still scanning for nearby URLs.">

	10 Looking for nearby Physical Web pages

	11 </message>

6 </grit-part>	12 </grit-part>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »