Don't pause suspended videos with no audio.

media/blink/webmediaplayer_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <stdint.h>
 
 #include <memory>
 
@@ skipping 301 matching lines @@
   void ForegroundPlayer() {
     delegate_.SetFrameHiddenForTesting(false);
     delegate_.SetFrameClosedForTesting(false);
     wmpi_->OnFrameShown();
   }
 
   void Play() { wmpi_->play(); }
 
   void Pause() { wmpi_->pause(); }
 
+  void ScheduleIdlePauseTimer() { wmpi_->ScheduleIdlePauseTimer(); }
+
+  bool IsIdlePauseTimerRunning() {
+    return wmpi_->background_pause_timer_.IsRunning();
+  }
+
+  void SetSuspendState(bool is_suspended) {
+    wmpi_->SetSuspendState(is_suspended);
+  }
+
   // "Renderer" thread.
   base::MessageLoop message_loop_;
 
   // "Media" thread. This is necessary because WMPI destruction waits on a
   // WaitableEvent.
   base::Thread media_thread_;
 
   // Blink state.
   blink::WebFrameClient web_frame_client_;
   blink::WebView* web_view_;
@@ skipping 407 matching lines @@
     blink::WebScopedUserGesture user_gesture(nullptr);
     Pause();
     EXPECT_TRUE(IsVideoLockedWhenPausedWhenHidden());
   }
 
   // Foregrounding the player unsets the lock.
   ForegroundPlayer();
   EXPECT_FALSE(IsVideoLockedWhenPausedWhenHidden());
 }
 
+TEST_F(WebMediaPlayerImplTest, BackgroundIdlePauseTimerDependsOnAudio) {
+  InitializeWebMediaPlayerImpl(true);
+  SetSuspendState(true);
+  SetPaused(false);
+
+  ASSERT_TRUE(IsSuspended());
+
+  // Video-only players are not paused when suspended.
+  SetMetadata(false, true);
+  ScheduleIdlePauseTimer();
+  EXPECT_FALSE(IsIdlePauseTimerRunning());
+
+  SetMetadata(true, true);
+  ScheduleIdlePauseTimer();
+  EXPECT_TRUE(IsIdlePauseTimerRunning());
+}
+
 class WebMediaPlayerImplBackgroundBehaviorTest
     : public WebMediaPlayerImplTest,
       public ::testing::WithParamInterface<
           std::tuple<bool, bool, int, int, bool>> {
  public:
   // Indices of the tuple parameters.
   static const int kIsMediaSuspendEnabled = 0;
   static const int kIsBackgroundOptimizationEnabled = 1;
   static const int kDurationSec = 2;
   static const int kAverageKeyframeDistanceSec = 3;
@@ skipping 132 matching lines @@
 
 INSTANTIATE_TEST_CASE_P(BackgroundBehaviorTestInstances,
                         WebMediaPlayerImplBackgroundBehaviorTest,
                         ::testing::Combine(::testing::Bool(),
                                            ::testing::Bool(),
                                            ::testing::Values(5, 300),
                                            ::testing::Values(5, 100),
                                            ::testing::Bool()));
 
 }  // namespace media