Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: media/blink/webmediaplayer_impl_unittest.cc

Issue 2696423003: Don't pause suspended videos with no audio. (Closed)
Patch Set: Added WMPI tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl_unittest.cc
diff --git a/media/blink/webmediaplayer_impl_unittest.cc b/media/blink/webmediaplayer_impl_unittest.cc
index ee63fedbcd176d194646f790293cfbb44fbebcb7..5eb1a8d74bbaab28ed0c6d5cc8bfc56ed7ab4c6c 100644
--- a/media/blink/webmediaplayer_impl_unittest.cc
+++ b/media/blink/webmediaplayer_impl_unittest.cc
@@ -319,6 +319,16 @@ class WebMediaPlayerImplTest : public testing::Test {
void Pause() { wmpi_->pause(); }
+ void ScheduleIdlePauseTimer() { wmpi_->ScheduleIdlePauseTimer(); }
+
+ bool IsIdlePauseTimerRunning() {
+ return wmpi_->background_pause_timer_.IsRunning();
+ }
+
+ void SetSuspendState(bool is_suspended) {
+ wmpi_->SetSuspendState(is_suspended);
+ }
+
// "Renderer" thread.
base::MessageLoop message_loop_;
@@ -746,6 +756,23 @@ TEST_F(WebMediaPlayerImplTest, VideoLockedWhenPausedWhenHidden) {
EXPECT_FALSE(IsVideoLockedWhenPausedWhenHidden());
}
+TEST_F(WebMediaPlayerImplTest, BackgroundIdlePauseTimerDependsOnAudio) {
+ InitializeWebMediaPlayerImpl(true);
+ SetSuspendState(true);
+ SetPaused(false);
+
+ ASSERT_TRUE(IsSuspended());
+
+ // Video-only players are not paused when suspended.
+ SetMetadata(false, true);
+ ScheduleIdlePauseTimer();
+ EXPECT_FALSE(IsIdlePauseTimerRunning());
+
+ SetMetadata(true, true);
+ ScheduleIdlePauseTimer();
+ EXPECT_TRUE(IsIdlePauseTimerRunning());
+}
+
class WebMediaPlayerImplBackgroundBehaviorTest
: public WebMediaPlayerImplTest,
public ::testing::WithParamInterface<
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698