s390: optimize for compares

s390: optimize for compares

1. use ltr/ltgr when possible
2. combine compares with possible load

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com

Review-Url: https://codereview.chromium.org/2696343002
Cr-Commit-Position: refs/heads/master@{#43265}
Committed: https://chromium.googlesource.com/v8/v8/+/37e9437e05a53b8c0c76914fa2e77d1e217286f8

[john.yan, 2017-02-16 02:38:46]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 02:38:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[john.yan, 2017-02-16 02:38:53]

ptal

[commit-bot: I haz the power, 2017-02-16 03:22:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 03:22:07]

Dry run: This issue passed the CQ dry run.

[JaideepBajwa, 2017-02-16 19:54:16]

lgtm

[john.yan, 2017-02-16 20:55:39]

The CQ bit was checked by jyan@ca.ibm.com

[john.yan, 2017-02-16 20:55:39]

The patchset sent to the CQ was uploaded after l-g-t-m from bjaideep@ca.ibm.com
Link to the patchset: https://codereview.chromium.org/2696343002/#ps20001
(title: "add or/xor")

[commit-bot: I haz the power, 2017-02-16 20:55:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 20:55:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 20:55:49]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[JoranSiu, 2017-02-16 21:59:16]

lgtm with one question.

https://codereview.chromium.org/2696343002/diff/20001/src/compiler/s390/instr...
File src/compiler/s390/instruction-selector-s390.cc (right):

https://codereview.chromium.org/2696343002/diff/20001/src/compiler/s390/instr...
src/compiler/s390/instruction-selector-s390.cc:1932: DCHECK(opcode >=
kS390_LoadAndTestWord32 ||
Should these be ==?

[john.yan, 2017-02-17 04:11:23]

On 2017/02/16 21:59:16, JoranSiu wrote:
> lgtm with one question.
> 
>
https://codereview.chromium.org/2696343002/diff/20001/src/compiler/s390/instr...
> File src/compiler/s390/instruction-selector-s390.cc (right):
> 
>
https://codereview.chromium.org/2696343002/diff/20001/src/compiler/s390/instr...
> src/compiler/s390/instruction-selector-s390.cc:1932: DCHECK(opcode >=
> kS390_LoadAndTestWord32 ||
> Should these be ==?

static_assert is added.

[john.yan, 2017-02-17 04:13:58]

The CQ bit was checked by jyan@ca.ibm.com

[john.yan, 2017-02-17 04:13:58]

The patchset sent to the CQ was uploaded after l-g-t-m from joransiu@ca.ibm.com,
bjaideep@ca.ibm.com
Link to the patchset: https://codereview.chromium.org/2696343002/#ps60001
(title: "add todo")

[commit-bot: I haz the power, 2017-02-17 04:14:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:34:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487304838205570,
"parent_rev": "50e269393b1479ae5ebf3909cdf2b9e60a1876db", "commit_rev":
"37e9437e05a53b8c0c76914fa2e77d1e217286f8"}

[commit-bot: I haz the power, 2017-02-17 04:34:58]

Description was changed from

==========
s390: optimize for compares

1. use ltr/ltgr when possible
2. combine compares with possible load

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com
==========

to

==========
s390: optimize for compares

1. use ltr/ltgr when possible
2. combine compares with possible load

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com

Review-Url: https://codereview.chromium.org/2696343002
Cr-Commit-Position: refs/heads/master@{#43265}
Committed:
https://chromium.googlesource.com/v8/v8/+/37e9437e05a53b8c0c76914fa2e77d1e217...
==========

[commit-bot: I haz the power, 2017-02-17 04:35:00]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/37e9437e05a53b8c0c76914fa2e77d1e217...