src/s390/macro-assembler-s390.cc - Issue 2696343002: s390: optimize for compares

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/s390/macro-assembler-s390.cc

Issue 2696343002: s390: optimize for compares (Closed)

Patch Set: add todo Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/s390/macro-assembler-s390.cc

diff --git a/src/s390/macro-assembler-s390.cc b/src/s390/macro-assembler-s390.cc

index ef82606012a04b5f5d841034509738d10d2375e0..bca8480a578d42ce45638cfad2e7b7ed019fe107 100644

--- a/src/s390/macro-assembler-s390.cc

+++ b/src/s390/macro-assembler-s390.cc

@@ -3331,7 +3331,10 @@ void MacroAssembler::MulHighU32(Register dst, Register src1,

void MacroAssembler::Mul32WithOverflowIfCCUnequal(Register dst, Register src1,

const MemOperand& src2) {

+ Register result = dst;

+ if (src2.rx().is(dst) || src2.rb().is(dst)) dst = r0;

Generate_Mul32WithOverflowIfCCUnequal(msgf);

+ if (!result.is(dst)) llgfr(result, dst);

}

void MacroAssembler::Mul32WithOverflowIfCCUnequal(Register dst, Register src1,

« no previous file with comments | « src/s390/disasm-s390.cc ('k') | src/s390/simulator-s390.h » ('j') | no next file with comments »