Fix NTP not showing error page when offline

Fix NTP not showing error page when offline

This is bug fix in relation with the following CL where
WebContentsObserver methods were updated for android.
https://codereview.chromium.org/2642303002/

BUG=692053
Review-Url: https://codereview.chromium.org/2695843003
Cr-Commit-Position: refs/heads/master@{#450570}
Committed: https://chromium.googlesource.com/chromium/src/+/1a352f47d7d018778726a37053792bda6cb0a7b9

[shaktisahu, 2017-02-14 20:36:11]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 20:36:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shaktisahu, 2017-02-14 20:37:29]

Description was changed from

==========
Fix NTP not showing error page when offline

This is bug fix in relation with the following CL where
WebContentsObserver methods were updated for android.
https://codereview.chromium.org/2642303002/

BUG=692053
==========

to

==========
Fix NTP not showing error page when offline

This is bug fix in relation with the following CL where
WebContentsObserver methods were updated for android.
https://codereview.chromium.org/2642303002/

BUG=692053
==========

[shaktisahu, 2017-02-14 20:37:29]

shaktisahu@chromium.org changed reviewers:
+ jam@chromium.org

[shaktisahu, 2017-02-14 20:39:40]

jam@ - PTAL

[jam, 2017-02-14 20:52:50]

lgtm

[jam, 2017-02-14 20:53:07]

can we add a test?

[commit-bot: I haz the power, 2017-02-14 21:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:26:02]

Dry run: This issue passed the CQ dry run.

[shaktisahu, 2017-02-15 00:08:29]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[shaktisahu, 2017-02-15 00:08:58]

The CQ bit was unchecked by shaktisahu@chromium.org

[David Trainor- moved to gerrit, 2017-02-15 00:19:20]

dtrainor@chromium.org changed reviewers:
+ dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-02-15 00:19:21]

lgtm!

https://codereview.chromium.org/2695843003/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java
(right):

https://codereview.chromium.org/2695843003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java:63:
final boolean[] isShowingError = new boolean[1];
AtomicBoolean is another way to do it.

[shaktisahu, 2017-02-15 00:24:07]

The CQ bit was checked by shaktisahu@chromium.org

[shaktisahu, 2017-02-15 00:24:07]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2695843003/#ps40001
(title: "Added a test")

[commit-bot: I haz the power, 2017-02-15 00:25:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 05:49:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487118247489900,
"parent_rev": "684418e9e512ef89bab2af1e0d0e99d055bc94a7", "commit_rev":
"1a352f47d7d018778726a37053792bda6cb0a7b9"}

[commit-bot: I haz the power, 2017-02-15 05:50:48]

Description was changed from

==========
Fix NTP not showing error page when offline

This is bug fix in relation with the following CL where
WebContentsObserver methods were updated for android.
https://codereview.chromium.org/2642303002/

BUG=692053
==========

to

==========
Fix NTP not showing error page when offline

This is bug fix in relation with the following CL where
WebContentsObserver methods were updated for android.
https://codereview.chromium.org/2642303002/

BUG=692053

Review-Url: https://codereview.chromium.org/2695843003
Cr-Commit-Position: refs/heads/master@{#450570}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a352f47d7d018778726a3705379...
==========

[commit-bot: I haz the power, 2017-02-15 05:50:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1a352f47d7d018778726a3705379...