android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java - Issue 2695843003: Fix NTP not showing error page when offline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

Issue 2695843003: Fix NTP not showing error page when offline (Closed)

Patch Set: Added a test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

index 38262899bf1d849c01f826acdd21f45fcd4debcf..ba41b16f7387d5b01293d5f3186b439c644c265f 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

@@ -93,7 +93,6 @@ public class AwWebContentsObserver extends WebContentsObserver {

Integer pageTransition, int errorCode, String errorDescription, int httpStatusCode) {

if (errorCode != 0) {

didFailLoad(isInMainFrame, errorCode, errorDescription, url);

- return;

}

if (!hasCommitted) return;