chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java - Issue 2695843003: Fix NTP not showing error page when offline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 2695843003: Fix NTP not showing error page when offline (Closed)

Patch Set: Added a test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

index cb2d19cc50368e03d62047f2bc1fc9e8cd1704de..b515d5b43dd1eb38d1a4719b028749a60a9b3813 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

@@ -215,7 +215,6 @@ public class TabWebContentsObserver extends WebContentsObserver {

if (isInMainFrame) mTab.didFailPageLoad(errorCode);

recordErrorInPolicyAuditor(url, errorDescription, errorCode);

- return;

}

if (!hasCommitted) return;