Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2695823008: Add missing #include around sequenced_worker_pool.h in //chrome (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, skanuj+watch_chromium.org, mcasas+watch+vc_chromium.org, zea+watch_chromium.org, tburkard+watch_chromium.org, chfremer+watch_chromium.org, johnme+watch_chromium.org, browser-components-watch_chromium.org, noyau+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, grt+watch_chromium.org, net-reviews_chromium.org, Jered, devtools-reviews_chromium.org, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, alemate+watch_chromium.org, ntp-dev+reviews_chromium.org, tapted, Peter Beverloo, Randy Smith (Not in Mondays), gavinp+prer_chromium.org, jfweitz+watch_chromium.org, pam+watch_chromium.org, asvitkine+watch_chromium.org, sync-reviews_chromium.org, oshima+watch_chromium.org, feature-media-reviews_chromium.org, tfarina, donnd+watch_chromium.org, David Black, pfeldman, samarth+watch_chromium.org, mac-reviews_chromium.org, kmadhusu+watch_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing #include around sequenced_worker_pool.h in //chrome This is a //chrome part of https://codereview.chromium.org/2690533002/ PS6. These files depends on indirectly-included sequenced_worker_pool.h, which is being removed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2695823008 Cr-Commit-Position: refs/heads/master@{#450892} Committed: https://chromium.googlesource.com/chromium/src/+/ebc7290a4f2d9e94b3f85cf57bf251971397cafd

Patch Set 1 #

Patch Set 2 : sync_websocket_impl & wizard_controller #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -5 lines) Patch
M chrome/browser/apps/drive/drive_service_bridge.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/budget_service/budget_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/component_updater/ev_whitelist_component_installer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/component_updater/sth_set_component_installer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/crash_upload_list/crash_upload_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/downgrade/user_data_downgrade.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/downgrade/user_data_downgrade_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/download/download_commands.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/favicon/large_icon_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gcm/gcm_profile_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gcm/gcm_profile_service_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/webrtc/desktop_media_list_ash.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_log_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/memory_details_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/memory_details_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/memory_details_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/memory_details_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/plugin_metrics_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/variations/chrome_variations_service_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/dns_probe_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/errorpage_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/file_downloader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/file_downloader_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/net/url_request_mock_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/platform_util_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/cloud/test_request_interceptor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_test_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/printing/print_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_extension_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ssl/security_state_tab_helper_browser_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_registration_utility.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_site_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_manager/sampling/shared_sampler_win_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_manager/sampling/task_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/themes/theme_service_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_test_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/desktop_ios_promotion/sms_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/search/new_tab_page_interceptor_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/elevation_icon_setter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/taskbar_decorator_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/image_source.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_loader_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_backend_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_capabilities.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/win/enumerate_modules_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (16 generated)
tzik
PTAL
3 years, 10 months ago (2017-02-15 11:57:07 UTC) #11
sky
LGTM
3 years, 10 months ago (2017-02-15 16:42:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695823008/20001
3 years, 10 months ago (2017-02-16 06:59:15 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 07:52:52 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ebc7290a4f2d9e94b3f85cf57bf2...

Powered by Google App Engine
This is Rietveld 408576698