Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2697933003: Add missing #include around sequenced_worker_pool.h (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
Reviewers:
slan, gab, sky, alokp
CC:
chromium-reviews, dtseng+watch_chromium.org, halliwell+watch_chromium.org, vmpstr+watch_chromium.org, aboxhall+watch_chromium.org, shuchen+watch_chromium.org, lcwu+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, asvitkine+watch_chromium.org, alokp+watch_chromium.org, James Su, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing #include around sequenced_worker_pool.h This is a non-essential part of https://codereview.chromium.org/2690533002/ PS9. These files depends on indirectly-included sequenced_worker_pool.h, which is being removed. Review-Url: https://codereview.chromium.org/2697933003 Cr-Commit-Position: refs/heads/master@{#450898} Committed: https://chromium.googlesource.com/chromium/src/+/47f63ccb56ee1e531bbfca94d4ea18b96d2ed561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M base/test/launcher/test_launcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/browser/metrics/external_metrics.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/browser/url_request_context_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/service_manager/runner/host/service_process_launcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/service_manager/standalone/context.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/atk_util_auralinux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/input_method_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/snapshot_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (12 generated)
tzik
PTAL to: sky: //ui, //services/service_manager slan: //chromecast gab: //base
3 years, 10 months ago (2017-02-15 12:14:45 UTC) #7
gab
On 2017/02/15 12:14:45, tzik wrote: > PTAL to: > sky: //ui, //services/service_manager > slan: //chromecast ...
3 years, 10 months ago (2017-02-15 14:25:59 UTC) #10
sky
LGTM
3 years, 10 months ago (2017-02-15 16:46:06 UTC) #11
alokp
chromecast/ lgtm
3 years, 10 months ago (2017-02-15 17:43:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697933003/1
3 years, 10 months ago (2017-02-16 08:21:44 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 08:35:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/47f63ccb56ee1e531bbfca94d4ea...

Powered by Google App Engine
This is Rietveld 408576698