Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2696613004: Add missing #include around sequenced_worker_pool.h in //content, //storage (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
Reviewers:
kinuko
CC:
chromium-reviews, asanka, tzik, johnme+watch_chromium.org, dcheng, rginda+watch_chromium.org, tracing+reviews_chromium.org, kinuko+watch, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, net-reviews_chromium.org, darin-cc_chromium.org, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, harkness+watch_chromium.org, blink-worker-reviews_chromium.org, jsbell+serviceworker_chromium.org, Peter Beverloo, Randy Smith (Not in Mondays), nhiroki, michaeln, shimazu+serviceworker_chromium.org, wfh+watch_chromium.org, serviceworker-reviews, kinuko+serviceworker, horo+watch_chromium.org, kinuko+fileapi, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing #include around sequenced_worker_pool.h in //content, //storage This is a storage related part of https://codereview.chromium.org/2690533002/ PS6. These files depends on indirectly-included sequenced_worker_pool.h, which is being removed. Review-Url: https://codereview.chromium.org/2696613004 Cr-Commit-Position: refs/heads/master@{#450879} Committed: https://chromium.googlesource.com/chromium/src/+/38dc09d11e83b60a667624a917d944ac8f4812bb

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_token.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/blob_storage/blob_storage_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/drag_download_file_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/url_loader_factory_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/net/quota_policy_cookie_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/push_messaging/push_messaging_router.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_database.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_unregister_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/test_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M storage/browser/blob/blob_data_handle.h View 1 chunk +1 line, -0 lines 0 comments Download
M storage/browser/quota/quota_manager.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (16 generated)
tzik
PTAL
3 years, 10 months ago (2017-02-15 08:19:58 UTC) #5
kinuko
lgtm
3 years, 10 months ago (2017-02-16 03:45:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696613004/20001
3 years, 10 months ago (2017-02-16 03:50:36 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-16 05:53:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696613004/20001
3 years, 10 months ago (2017-02-16 06:06:27 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 06:38:23 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/38dc09d11e83b60a667624a917d9...

Powered by Google App Engine
This is Rietveld 408576698