Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2694413003: Revert of Mus Demo: Move definition of WindowTreeData into separate files. (Closed)

Created:
3 years, 10 months ago by bruthig
Modified:
3 years, 10 months ago
Reviewers:
kylechar, fwang
CC:
chromium-reviews, rjkroege, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mus Demo: Move definition of WindowTreeData into separate files. (patchset #4 id:60001 of https://codereview.chromium.org/2694843005/ ) Reason for revert: This change appears to have broken the compile step of the following build: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/8536 Original issue's description: > Mus Demo: Move definition of WindowTreeData into mus_demo.h > > In follow-up CLs, MusDemo will be split into two derived classes > demonstrating external and internal modes. These classes will handle > instances of WindowTreeData and for that purpose this CL moves the > definition of WindowTreeData into separate files. We also adjust a bit > the Constructor/Init to help in future CLs. > > BUG=666958 > R=kylechar@chromium.org > > Review-Url: https://codereview.chromium.org/2694843005 > Cr-Commit-Position: refs/heads/master@{#450726} > Committed: https://chromium.googlesource.com/chromium/src/+/da4637b0c789f6360dacdea216dd5316972862ee TBR=kylechar@chromium.org,fwang@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=666958 Review-Url: https://codereview.chromium.org/2694413003 Cr-Commit-Position: refs/heads/master@{#450742} Committed: https://chromium.googlesource.com/chromium/src/+/03f2053328cb3ab19f5c5a0348cc3581576bbe49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -192 lines) Patch
M services/ui/demo/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/demo/mus_demo.h View 2 chunks +1 line, -2 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 5 chunks +138 lines, -6 lines 0 comments Download
D services/ui/demo/window_tree_data.h View 1 chunk +0 lines, -60 lines 0 comments Download
D services/ui/demo/window_tree_data.cc View 1 chunk +0 lines, -122 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bruthig
Created Revert of Mus Demo: Move definition of WindowTreeData into separate files.
3 years, 10 months ago (2017-02-15 18:22:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694413003/1
3 years, 10 months ago (2017-02-15 18:22:56 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 18:24:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/03f2053328cb3ab19f5c5a0348cc...

Powered by Google App Engine
This is Rietveld 408576698