Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2694193004: Early out PrePaintTreeWalk::walk() earlier (Closed)

Created:
3 years, 10 months ago by Xianzhu
Modified:
3 years, 10 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Early out PrePaintTreeWalk::walk() earlier We should have paint invalidation flags set when auxiliary object properties and/or paint offset will change (otherwise we will not reach some of such objects because of the early return of the upper level), so they can be below the early return. BUG=685179 TEST=all existing tests pass CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 R=chrishtr@chromium.org Review-Url: https://codereview.chromium.org/2694193004 . Cr-Commit-Position: refs/heads/master@{#450884} Committed: https://chromium.googlesource.com/chromium/src/+/5b35a06876222a78be4405d86e712fb17bf6fa8b

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 1 chunk +5 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (21 generated)
Xianzhu
3 years, 10 months ago (2017-02-14 23:53:46 UTC) #13
chrishtr
lgtm Please wait for pdr's review also though.
3 years, 10 months ago (2017-02-15 02:05:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694193004/60001
3 years, 10 months ago (2017-02-16 07:05:38 UTC) #23
Xianzhu
3 years, 10 months ago (2017-02-16 07:08:33 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
5b35a06876222a78be4405d86e712fb17bf6fa8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698