Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2694193004: Early out PrePaintTreeWalk::walk() earlier (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index afbc9f1af66823c81371d53ffdfb6adddb601eb8..172d22ae06ce77eada4f4fe52677f2594f78548b 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -919,7 +919,7 @@ void PaintPropertyTreeBuilder::updatePaintOffset(
}
}
-void PaintPropertyTreeBuilder::updateContextForBoxPosition(
+void PaintPropertyTreeBuilder::updateForObjectLocation(
const LayoutObject& object,
PaintPropertyTreeBuilderContext& context) {
if (object.isBoxModelObject()) {
@@ -944,6 +944,10 @@ void PaintPropertyTreeBuilder::updateContextForBoxPosition(
void PaintPropertyTreeBuilder::updatePropertiesForSelf(
const LayoutObject& object,
PaintPropertyTreeBuilderContext& context) {
+ // This is not in FindObjectPropertiesNeedingUpdateScope because paint offset
+ // can change without needsPaintPropertyUpdate.
+ updateForObjectLocation(object, context);
+
#if DCHECK_IS_ON()
FindObjectPropertiesNeedingUpdateScope checkNeedsUpdateScope(object, context);
#endif

Powered by Google App Engine
This is Rietveld 408576698