Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2694103007: [Devtools] Fixes network group to remove parents if no child (Closed)

Created:
3 years, 10 months ago by allada
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixes network group to remove parents if no child This patch removes parents of grouped network items if there are no children in the parents. BUG=664704 R=pfeldman Review-Url: https://codereview.chromium.org/2694103007 Cr-Commit-Position: refs/heads/master@{#450877} Committed: https://chromium.googlesource.com/chromium/src/+/1edc35f110d1a463f9809286478c3f0dee9e1761

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 2 chunks +1 line, -4 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
allada
PTL
3 years, 10 months ago (2017-02-16 01:30:19 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2694103007/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (left): https://codereview.chromium.org/2694103007/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#oldcode803 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:803: if (node[Network.NetworkLogView._isFilteredOutSymbol] === isFilteredOut) offtopic: why do we ...
3 years, 10 months ago (2017-02-16 01:55:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694103007/1
3 years, 10 months ago (2017-02-16 04:25:34 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 06:38:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1edc35f110d1a463f9809286478c...

Powered by Google App Engine
This is Rietveld 408576698