Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2694103007: [Devtools] Fixes network group to remove parents if no child (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index aecd2030376bc474fe236ac632ba054860d44e3b..b408c94daa1016ebf62d75f9c10c5c399288bd46 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -800,9 +800,6 @@ Network.NetworkLogView = class extends UI.VBox {
this._timeCalculator.updateBoundaries(request);
this._durationCalculator.updateBoundaries(request);
- if (node[Network.NetworkLogView._isFilteredOutSymbol] === isFilteredOut)
pfeldman 2017/02/16 01:55:14 offtopic: why do we actually need this symbol at a
- continue;
-
node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
var newParent = this._parentNodeForInsert(node);
var removeFromParent = node.parent && (isFilteredOut || node.parent !== newParent);
@@ -816,7 +813,7 @@ Network.NetworkLogView = class extends UI.VBox {
}
}
- if (isFilteredOut)
+ if (!newParent || isFilteredOut)
continue;
if (!newParent.dataGrid && !nodesToInsert.has(newParent)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698