[Devtools] Added Product Registry module in prep for Network Grouping

[Devtools] Added Product Registry module in prep for Network Grouping

This patch adds product registry module that will be in charge of a map
that contains which groups a url will fall under. It is pretty much just
a map of url -> groupName.

R=pfeldman
BUG=664704
Review-Url: https://codereview.chromium.org/2696183005
Cr-Commit-Position: refs/heads/master@{#450914}
Committed: https://chromium.googlesource.com/chromium/src/+/2513615ece62e266bfe3868fa916826ba5eb9056

[allada, 2017-02-16 01:40:53]

Description was changed from

==========
[Devtools] Added Product Registry module in prep for Network Grouping

This patch adds product registry module that will be in charge of a map
that contains which groups a url will fall under. It is pretty much just
a map of url -> groupName.

R=pfeldman
BUG=664704
==========

to

==========
[Devtools] Added Product Registry module in prep for Network Grouping

This patch adds product registry module that will be in charge of a map
that contains which groups a url will fall under. It is pretty much just
a map of url -> groupName.

R=pfeldman
BUG=664704
==========

[allada, 2017-02-16 01:40:53]

allada@chromium.org changed reviewers:
+ dgozman@chromium.org

[allada, 2017-02-16 01:41:05]

Patchset #1 (id:1) has been deleted

[allada, 2017-02-16 01:43:04]

PTL

[pfeldman, 2017-02-16 01:48:04]

lgtm % nits.

https://codereview.chromium.org/2696183005/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/product_registry/ProductNameForURL.js
(right):

https://codereview.chromium.org/2696183005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/product_registry/ProductNameForURL.js:11:
var domain = parsedUrl.domain();
data urls don't have domains.

https://codereview.chromium.org/2696183005/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/product_registry/ProductRegistryData.js
(right):

https://codereview.chromium.org/2696183005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/product_registry/ProductRegistryData.js:4:
ProductRegistry._productsByDomain = {
You are using private variable from another file. Also, use a map instead.

[allada, 2017-02-16 04:23:30]

done

https://codereview.chromium.org/2696183005/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/product_registry/ProductNameForURL.js
(right):

https://codereview.chromium.org/2696183005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/product_registry/ProductNameForURL.js:11:
var domain = parsedUrl.domain();
On 2017/02/16 01:48:04, pfeldman wrote:
> data urls don't have domains.

Done.

https://codereview.chromium.org/2696183005/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/product_registry/ProductRegistryData.js
(right):

https://codereview.chromium.org/2696183005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/product_registry/ProductRegistryData.js:4:
ProductRegistry._productsByDomain = {
On 2017/02/16 01:48:04, pfeldman wrote:
> You are using private variable from another file. Also, use a map instead.

Done.

[allada, 2017-02-16 04:24:12]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 04:24:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 06:26:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 06:26:52]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[allada, 2017-02-16 08:16:51]

The CQ bit was checked by allada@chromium.org

[allada, 2017-02-16 08:16:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2696183005/#ps40001
(title: "changes")

[commit-bot: I haz the power, 2017-02-16 08:17:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 09:20:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487233011891410,
"parent_rev": "1d8aad917a21e1328d314cac566e2ee607fad1f4", "commit_rev":
"2513615ece62e266bfe3868fa916826ba5eb9056"}

[commit-bot: I haz the power, 2017-02-16 09:20:54]

Description was changed from

==========
[Devtools] Added Product Registry module in prep for Network Grouping

This patch adds product registry module that will be in charge of a map
that contains which groups a url will fall under. It is pretty much just
a map of url -> groupName.

R=pfeldman
BUG=664704
==========

to

==========
[Devtools] Added Product Registry module in prep for Network Grouping

This patch adds product registry module that will be in charge of a map
that contains which groups a url will fall under. It is pretty much just
a map of url -> groupName.

R=pfeldman
BUG=664704

Review-Url: https://codereview.chromium.org/2696183005
Cr-Commit-Position: refs/heads/master@{#450914}
Committed:
https://chromium.googlesource.com/chromium/src/+/2513615ece62e266bfe3868fa916...
==========

[commit-bot: I haz the power, 2017-02-16 09:20:55]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2513615ece62e266bfe3868fa916...