Chromium Code Reviews
Help | Chromium Project | Sign in
(66)

Issue 2693703010: cc: Remove support for disabling non-root render surfaces.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by danakj
Modified:
1 month ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, boliu, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove support for disabling non-root render surfaces. This mode was used by Android Webview to have everything draw into the root surface. However, the mode is no longer used making this code all dead as of https://codereview.chromium.org/2698793002/. Historically this mode existed because the compositor was in GL mode making allocating and using software resources for a software draw very awkward. Now the software draws are delegated to a separate cc::Display instance which is completely independent and able to deal with allocating and using software resources without being problematic. R=ajuma@chromium.org, weiliangc@chromium.org BUG=692780 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Patch Set 2 : softwaredraw-remove-no-surfaces: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1029 lines) Patch
M cc/layers/layer_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/output/bsp_tree_perftest.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M cc/trees/clip_node.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/clip_node.cc View 5 chunks +0 lines, -9 lines 0 comments Download
M cc/trees/draw_property_utils.h View 3 chunks +2 lines, -6 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 19 chunks +28 lines, -119 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 13 chunks +8 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 11 chunks +2 lines, -828 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/property_tree.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/property_tree.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Trybot results:  linux_android_rel_ng   android_clang_dbg_recipe   ios-device-xcode-clang   win_chromium_compile_dbg_ng   linux_chromium_compile_dbg_ng   linux_chromium_asan_rel_ng   android_compile_dbg   cast_shell_android   cast_shell_linux   ios-device   chromium_presubmit   win_chromium_rel_ng   mac_chromium_rel_ng   win_clang   android_cronet   chromeos_amd64-generic_chromium_compile_only_ng   mac_chromium_compile_dbg_ng   chromeos_daisy_chromium_compile_only_ng   ios-simulator-xcode-clang   linux_chromium_tsan_rel_ng   linux_chromium_chromeos_rel_ng   win_chromium_x64_rel_ng   linux_chromium_rel_ng   ios-simulator   android_arm64_dbg_recipe   linux_chromium_chromeos_ozone_rel_ng   linux_trusty_blink_rel   android_n5x_swarming_rel   linux_chromium_asan_rel_ng   linux_android_rel_ng   linux_chromium_tsan_rel_ng   win_chromium_compile_dbg_ng   win_chromium_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   android_cronet   ios-simulator-xcode-clang   mac_chromium_compile_dbg_ng   android_n5x_swarming_rel   cast_shell_linux   ios-simulator   linux_trusty_blink_rel   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   cast_shell_android   ios-device-xcode-clang   win_clang   chromeos_daisy_chromium_compile_only_ng   mac_chromium_rel_ng   ios-device   linux_chromium_compile_dbg_ng   chromium_presubmit   win_chromium_x64_rel_ng   linux_chromium_chromeos_ozone_rel_ng   android_compile_dbg   android_arm64_dbg_recipe   android_clang_dbg_recipe  Sign in to try more bots
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 21 (16 generated)
danakj
Probably don't review this yet cuz the patch it depends on has to get to ...
1 month, 1 week ago (2017-02-15 22:38:12 UTC) #3
weiliangc
LGTM. \o/ This makes me so happy :D
1 month, 1 week ago (2017-02-17 00:30:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693703010/20001
1 month ago (2017-02-23 19:42:47 UTC) #16
boliu
yeah this needs to wait until m58 goes stable, since webview beta channel is effectively ...
1 month ago (2017-02-23 19:47:45 UTC) #19
danakj
1 month ago (2017-02-23 20:11:19 UTC) #21
Yep I'll ask for a re-review then. Thanks for looking!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62