cc: Remove support for disabling non-root render surfaces.

cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead as of https://codereview.chromium.org/2698793002/.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2693703010
Cr-Commit-Position: refs/heads/master@{#470399}
Committed: https://chromium.googlesource.com/chromium/src/+/dc24211f2acd2182ec5ab009fcc03d8f448169d8

[danakj, 2017-02-15 22:37:49]

Description was changed from

==========
cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
==========

to

==========
cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[danakj, 2017-02-15 22:37:50]

Description was changed from

==========
cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-02-15 22:38:12]

Probably don't review this yet cuz the patch it depends on has to get to stable.
But FYI this exists and I'll ping it later.

[danakj, 2017-02-15 22:38:23]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 22:39:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-02-15 22:39:37]

Description was changed from

==========
cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-02-15 22:39:59]

Description was changed from

==========
cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead as of https://codereview.chromium.org/2698793002/.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2017-02-16 00:41:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 00:41:42]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[danakj, 2017-02-16 19:12:25]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 19:14:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 22:16:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 22:16:26]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2017-02-17 00:30:38]

LGTM.

\o/ This makes me so happy :D

[weiliangc, 2017-02-23 19:42:24]

The CQ bit was checked by weiliangc@chromium.org

[commit-bot: I haz the power, 2017-02-23 19:42:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2017-02-23 19:43:31]

The CQ bit was unchecked by ajuma@chromium.org

[boliu, 2017-02-23 19:47:44]

boliu@chromium.org changed reviewers:
+ boliu@chromium.org

[boliu, 2017-02-23 19:47:45]

yeah this needs to wait until m58 goes stable, since webview beta channel is
effectively nothing, and webview doesn't support experiments

[boliu, 2017-02-23 19:47:57]

boliu@chromium.org changed reviewers:
- boliu@chromium.org

[danakj, 2017-02-23 20:11:19]

Yep I'll ask for a re-review then. Thanks for looking!

[boliu, 2017-05-05 20:23:57]

I think m58 has been stable long enough and haven't heard any major issues. So I
think this can land now :)

[danakj, 2017-05-05 20:26:35]

Ooh thanks I forgot :D

On Fri, May 5, 2017 at 4:23 PM, <boliu@chromium.org> wrote:

> I think m58 has been stable long enough and haven't heard any major
> issues. So I
> think this can land now :)
>
> https://codereview.chromium.org/2693703010/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2017-05-05 20:26:36]

Ooh thanks I forgot :D

On Fri, May 5, 2017 at 4:23 PM, <boliu@chromium.org> wrote:

> I think m58 has been stable long enough and haven't heard any major
> issues. So I
> think this can land now :)
>
> https://codereview.chromium.org/2693703010/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2017-05-05 20:57:54]

I've rebased and there was a lot of conflicts to resolve. Wei would you mind
reviewing again to see if I didn't do anything wrong and there's nothing you
know of that I missed? Thanks!

[danakj, 2017-05-05 20:58:09]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 20:59:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 21:22:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 21:22:21]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[danakj, 2017-05-09 14:19:28]

@weiliangc: ping

[danakj, 2017-05-09 14:19:52]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 14:20:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[weiliangc, 2017-05-09 15:41:15]

On 2017/05/09 14:19:28, danakj wrote:
> @weiliangc: ping

LGTM.
Sorry didn't realize there is new stuff when I saw this on my code review list.

[danakj, 2017-05-09 15:42:39]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2017-05-09 15:42:43]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-05-09 15:43:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 18:58:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494344563603330,
"parent_rev": "68dec6c7fc15ecf857449cb941793eebbd4b2589", "commit_rev":
"dc24211f2acd2182ec5ab009fcc03d8f448169d8"}

[commit-bot: I haz the power, 2017-05-09 18:58:44]

Description was changed from

==========
cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead as of https://codereview.chromium.org/2698793002/.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Remove support for disabling non-root render surfaces.

This mode was used by Android Webview to have everything draw into
the root surface. However, the mode is no longer used making this
code all dead as of https://codereview.chromium.org/2698793002/.

Historically this mode existed because the compositor was in GL mode
making allocating and using software resources for a software draw
very awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

R=ajuma@chromium.org, weiliangc@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2693703010
Cr-Commit-Position: refs/heads/master@{#470399}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc24211f2acd2182ec5ab009fcc0...
==========

[commit-bot: I haz the power, 2017-05-09 18:58:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dc24211f2acd2182ec5ab009fcc0...