cc: Enable use of render surfaces for Android WebView

cc: Enable use of render surfaces for Android WebView

This was disabled because the compositor was in GL mode making
allocating and using software resources for a software draw very
awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=boliu@chromium.org, aelias@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2698793002
Cr-Commit-Position: refs/heads/master@{#451117}
Committed: https://chromium.googlesource.com/chromium/src/+/e9cf581d97cce0939cc6ce4f1a60767a8a28602f

[danakj, 2017-02-15 22:35:46]

Description was changed from

==========
cc: Enable use of render surfaces for Android WebView

This was disabled because the compositor was in GL mode making
allocating and using software resources for a software draw very
awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=boliu@chromium.org
BUG=692780
==========

to

==========
cc: Enable use of render surfaces for Android WebView

This was disabled because the compositor was in GL mode making
allocating and using software resources for a software draw very
awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=boliu@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-02-15 22:38:18]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 22:39:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-02-15 23:45:34]

Description was changed from

==========
cc: Enable use of render surfaces for Android WebView

This was disabled because the compositor was in GL mode making
allocating and using software resources for a software draw very
awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=boliu@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Enable use of render surfaces for Android WebView

This was disabled because the compositor was in GL mode making
allocating and using software resources for a software draw very
awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=boliu@chromium.org, aelias@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-02-15 23:45:34]

danakj@chromium.org changed reviewers:
+ aelias@chromium.org

[danakj, 2017-02-15 23:45:44]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 23:46:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-02-15 23:47:03]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 23:47:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-02-16 00:16:29]

PS3 lgtm

[commit-bot: I haz the power, 2017-02-16 01:50:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:50:09]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[danakj, 2017-02-16 16:00:00]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-02-16 16:00:06]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2017-02-16 16:00:18]

aelias PTAL at content/renderer/

[danakj, 2017-02-16 19:11:51]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 19:13:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 20:20:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 20:20:21]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2017-02-16 21:37:48]

lgtm

[danakj, 2017-02-16 21:39:50]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-02-16 21:40:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 22:22:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487281190224680,
"parent_rev": "f160102d25fb949a3ed24478268b8835cc086477", "commit_rev":
"e9cf581d97cce0939cc6ce4f1a60767a8a28602f"}

[commit-bot: I haz the power, 2017-02-16 22:23:47]

Description was changed from

==========
cc: Enable use of render surfaces for Android WebView

This was disabled because the compositor was in GL mode making
allocating and using software resources for a software draw very
awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=boliu@chromium.org, aelias@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Enable use of render surfaces for Android WebView

This was disabled because the compositor was in GL mode making
allocating and using software resources for a software draw very
awkward. Now the software draws are delegated to a separate
cc::Display instance which is completely independent and able
to deal with allocating and using software resources without being
problematic.

It's also possible that using render surfaces (which also allows)
composited effects such as filters will cause a performance problem.
This seems unlikely as all of these same effects can be done during
painting, however. This patch is a minimal one to just change the
behaviour to allowing render surfaces in order to verify things
don't all fall apart. The code to support it can be removed later.

R=boliu@chromium.org, aelias@chromium.org
BUG=692780
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2698793002
Cr-Commit-Position: refs/heads/master@{#451117}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9cf581d97cce0939cc6ce4f1a60...
==========

[commit-bot: I haz the power, 2017-02-16 22:23:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e9cf581d97cce0939cc6ce4f1a60...