Issue 2693573002: Remove unused WebWindowFeatures from popup blocker, reducing WebString use in browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2693573002: Remove unused WebWindowFeatures from popup blocker, reducing WebString use in browser (Closed)

Created:
3 years, 10 months ago by scottmg

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, jam, kinuko+watch, darin-cc_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove unused WebWindowFeatures from popup blocker, reducing WebString use in browser BUG=248653

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -48 lines)			Patch
M	chrome/browser/android/tab_web_contents_delegate_android.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc	View	4 chunks	+8 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/platform/BUILD.gn	View	4 chunks	+9 lines, -8 lines	0 comments	Download

Depends on Patchset: