chrome/browser/ui/browser.cc - Issue 2693573002: Remove unused WebWindowFeatures from popup blocker, reducing WebString use in browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 2693573002: Remove unused WebWindowFeatures from popup blocker, reducing WebString use in browser (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 873a47e4b7821e7a50f9a19abc0675a7194e70c9..ec9b7f178fa09e8aa914561ee26334419180ff1d 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -1405,8 +1405,7 @@ WebContents* Browser::OpenURLFromTab(WebContents* source,

!params.user_gesture &&

!base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDisablePopupBlocking)) {

- if (popup_blocker_helper->MaybeBlockPopup(nav_params,

- WebWindowFeatures())) {

+ if (popup_blocker_helper->MaybeBlockPopup(nav_params)) {

return NULL;

}