Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h

Issue 2693573002: Remove unused WebWindowFeatures from popup blocker, reducing WebString use in browser (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h
diff --git a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h
index 0e0fabce0b8b19a9861ae279a77317a7680c5d4f..8babaec5b2ea5e0b8ef33769d5d6e8f63d4c41c6 100644
--- a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h
+++ b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h
@@ -20,10 +20,6 @@ namespace chrome {
struct NavigateParams;
}
-namespace blink {
-struct WebWindowFeatures;
-}
-
class GURL;
// Per-tab class to manage blocked popups.
@@ -38,8 +34,7 @@ class PopupBlockerTabHelper
// Returns true if the popup request defined by |params| should be blocked.
// In that case, it is also added to the |blocked_popups_| container.
- bool MaybeBlockPopup(const chrome::NavigateParams& params,
- const blink::WebWindowFeatures& window_features);
+ bool MaybeBlockPopup(const chrome::NavigateParams& params);
// Adds a popup request to the |blocked_popups_| container.
void AddBlockedPopup(const BlockedWindowParams& params);
@@ -62,8 +57,7 @@ class PopupBlockerTabHelper
explicit PopupBlockerTabHelper(content::WebContents* web_contents);
- void AddBlockedPopup(const chrome::NavigateParams& params,
- const blink::WebWindowFeatures& window_features);
+ void AddBlockedPopup(const chrome::NavigateParams& params);
// Called when the blocked popup notification is shown or hidden.
void PopupNotificationVisibilityChanged(bool visible);

Powered by Google App Engine
This is Rietveld 408576698