Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4757)

Unified Diff: chrome/browser/android/tab_web_contents_delegate_android.cc

Issue 2693573002: Remove unused WebWindowFeatures from popup blocker, reducing WebString use in browser (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/tab_web_contents_delegate_android.cc
diff --git a/chrome/browser/android/tab_web_contents_delegate_android.cc b/chrome/browser/android/tab_web_contents_delegate_android.cc
index 9074acfe6329de24a2eeff4255d575f074e1fb83..60dfb9e5423b8a4f5f967afbe349c25360ed5811 100644
--- a/chrome/browser/android/tab_web_contents_delegate_android.cc
+++ b/chrome/browser/android/tab_web_contents_delegate_android.cc
@@ -330,8 +330,7 @@ WebContents* TabWebContentsDelegateAndroid::OpenURLFromTab(
!params.user_gesture &&
!base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisablePopupBlocking)) {
- if (popup_blocker_helper->MaybeBlockPopup(nav_params,
- blink::WebWindowFeatures())) {
+ if (popup_blocker_helper->MaybeBlockPopup(nav_params)) {
return nullptr;
}
}
« no previous file with comments | « no previous file | chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698