Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 2692943006: Only include unique files in generated ComputedStyleBase.h (Closed)

Created:
3 years, 10 months ago by shend
Modified:
3 years, 10 months ago
Reviewers:
meade_UTC10, Bugs Nash
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only include unique files in generated ComputedStyleBase.h Currently files included in ComputedStyleBase.h can be duplicated. When we introduce platform types, we expect lots of duplicate includes. Duplicates don't won't break things, but does slow down compilation. This patch makes sure that the include files are unique and sorted alphabetically. As a nice side-effect, we can remove type_path from the Field class since it's only used to obtain the include files. BUG=628043 Review-Url: https://codereview.chromium.org/2692943006 Cr-Commit-Position: refs/heads/master@{#451554} Committed: https://chromium.googlesource.com/chromium/src/+/97670d39c3a534c68f5ec0131c6baefbccc99602

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Sort includes #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 2 3 4 7 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
shend
Hi Bugs, PTAL :)
3 years, 10 months ago (2017-02-14 02:45:18 UTC) #2
Bugs Nash
lgtm
3 years, 10 months ago (2017-02-14 02:59:41 UTC) #3
shend
Hi Eddy PTAL :)
3 years, 10 months ago (2017-02-14 03:01:20 UTC) #5
meade_UTC10
lgtm
3 years, 10 months ago (2017-02-15 05:53:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692943006/80002
3 years, 10 months ago (2017-02-20 01:51:46 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 03:37:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #6 (id:80002) as
https://chromium.googlesource.com/chromium/src/+/97670d39c3a534c68f5ec0131c6b...

Powered by Google App Engine
This is Rietveld 408576698