Only include unique files in generated ComputedStyleBase.h

third_party/WebKit/Source/build/scripts/make_computed_style_base.py

 #!/usr/bin/env python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import math
 import sys
 
 import json5_generator
 import template_expander
@@ skipping 30 matching lines @@
     # List of required attributes for a field which need to be passed in by
     # keyword arguments. See CSSProperties.json5 for an explanation of each
     # attribute.
     REQUIRED_ATTRIBUTES = set([
         # Name of field
         'name',
         # Name of property field is for
         'property_name',
         # Name of the type (e.g. EClear, int)
         'type_name',
-        # Path to predefined class for overriding generated types.
-        'field_type_path',
         # Affects how the field is generated (keyword, flag)
         'field_template',
         # Bits needed for storage
         'size',
         # Default value for field
         'default_value',
         # Method names
         'getter_method_name',
         'setter_method_name',
         'initial_method_name',
@@ skipping 19 matching lines @@
             assert self.is_inherited or not self.is_independent, 'Only inherited fields can be independent'
 
             self.is_inherited_method_name = kwargs.pop('is_inherited_method_name')
         elif self.is_inherited_flag:
             # Inherited flag-only fields
             pass
 
         assert len(kwargs) == 0, 'Unexpected arguments provided to Field: ' + str(kwargs)
 
 
+def _get_include_paths(properties):
+    """
+    Get a list of paths that need to be included for ComputedStyleBase.
+    """
+    include_paths = set()
+    for property_ in properties:
+        if property_['field_type_path'] is not None:
+            include_paths.add(property_['field_type_path'] + '.h')
+    return list(sorted(include_paths))
+
+
 def _create_enums(properties):
     """
     Returns a dictionary of enums to be generated, enum name -> [list of enum values]
     """
     enums = {}
     for property_ in properties:
         # Only generate enums for keyword properties that use the default field_type_path.
         if property_['field_template'] == 'keyword' and property_['field_type_path'] is None:
             enum_name = property_['type_name']
             # From the Blink style guide: Enum members should use InterCaps with an initial capital letter. [names-enum-members]
@@ skipping 17 matching lines @@
     """
     property_name = property_['name_for_methods']
     property_name_lower = lower_first(property_name)
 
     # From the Blink style guide: Other data members should be prefixed by "m_". [names-data-members]
     field_name = 'm_' + property_name_lower
     bits_needed = math.log(len(property_['keywords']), 2)  # TODO: implement for non-enums
 
     # Separate the type path from the type name, if specified.
     if property_['field_type_path']:
-        field_type_path = property_['field_type_path']
-        type_name = field_type_path.split('/')[-1]
+        type_name = property_['field_type_path'].split('/')[-1]
     else:
-        field_type_path = None
         type_name = property_['type_name']
 
     # For now, the getter name should match the field name. Later, getter names
     # will start with an uppercase letter, so if they conflict with the type name,
     # add 'get' to the front.
     getter_method_name = property_name_lower
     if type_name == property_name:
         getter_method_name = 'get' + property_name
 
     assert property_['initial_keyword'] is not None, \
         ('MakeComputedStyleBase requires an initial keyword for keyword fields, none specified '
          'for property ' + property_['name'])
     default_value = type_name + '::k' + camel_case(property_['initial_keyword'])
 
     return Field(
         'property',
         name=field_name,
         property_name=property_['name'],
         inherited=property_['inherited'],
         independent=property_['independent'],
         type_name=type_name,
-        field_type_path=field_type_path,
         field_template=property_['field_template'],
         size=int(math.ceil(bits_needed)),
         default_value=default_value,
         getter_method_name=getter_method_name,
         setter_method_name='set' + property_name,
         initial_method_name='initial' + property_name,
         resetter_method_name='reset' + property_name,
         is_inherited_method_name=property_name_lower + 'IsInherited',
     )
 
 
 def _create_inherited_flag_field(property_):
     """
     Create the field used for an inheritance fast path from an independent CSS property,
     and return the Field object.
     """
     property_name = property_['name_for_methods']
     property_name_lower = lower_first(property_name)
 
     field_name_suffix_upper = property_name + 'IsInherited'
     field_name_suffix_lower = property_name_lower + 'IsInherited'
 
     return Field(
         'inherited_flag',
         name='m_' + field_name_suffix_lower,
         property_name=property_['name'],
         type_name='bool',
-        field_type_path=None,
         field_template='flag',
         size=1,
         default_value='true',
         getter_method_name=field_name_suffix_lower,
         setter_method_name='set' + field_name_suffix_upper,
         initial_method_name='initial' + field_name_suffix_upper,
         resetter_method_name='reset' + field_name_suffix_upper,
     )
 
 
 def _create_nonproperty_field(field_name):
     """
     Create a nonproperty field from its name and return the Field object.
     """
     member_name = 'm_' + field_name
     field_name_upper = upper_first_letter(field_name)
 
     return Field(
         'nonproperty',
         name=member_name,
         property_name=field_name,
         type_name='bool',
-        field_type_path=None,
         field_template='flag',
         size=1,
         default_value='false',
         getter_method_name=field_name,
         setter_method_name='set' + field_name_upper,
         initial_method_name='initial' + field_name_upper,
         resetter_method_name='reset' + field_name_upper,
     )
 
 
@@ skipping 94 matching lines @@
         for bucket in field_buckets:
             for field in bucket:
                 self._fields.append(field)
 
 
     @template_expander.use_jinja('ComputedStyleBase.h.tmpl')
     def generate_base_computed_style_h(self):
         return {
             'properties': self._properties,
             'enums': self._generated_enums,
+            'include_paths': _get_include_paths(self._properties.values()),
             'fields': self._fields,
             'expected_total_field_bytes': self._expected_total_field_bytes,
         }
 
     @template_expander.use_jinja('ComputedStyleBase.cpp.tmpl')
     def generate_base_computed_style_cpp(self):
         return {
             'properties': self._properties,
             'enums': self._generated_enums,
             'fields': self._fields,
             'expected_total_field_bytes': self._expected_total_field_bytes,
         }
 
     @template_expander.use_jinja('ComputedStyleBaseConstants.h.tmpl')
     def generate_base_computed_style_constants(self):
         return {
             'properties': self._properties,
             'enums': self._generated_enums,
             'fields': self._fields,
             'expected_total_field_bytes': self._expected_total_field_bytes,
         }
 
 if __name__ == '__main__':
     json5_generator.Maker(ComputedStyleBaseWriter).main()