Gut ash::MaterialDesignController, and remove the about:flags entry.

Gut ash::MaterialDesignController, and remove the about:flags entry.

It's not removed completely because IsXXXMaterial() is still used in
many places and serves as a good marker for code cleanup, but it no
longer does anything useful.

A bunch of tests are updated as well to remove parameterization. The
amount of overlap with bug 685837 was not originally intended, but at a
certain point it became easier to keep removing code than to carefully
determine dependencies.

BUG=690048, 685837
Review-Url: https://codereview.chromium.org/2692663002
Cr-Commit-Position: refs/heads/master@{#450531}
Committed: https://chromium.googlesource.com/chromium/src/+/a23d6ceb29374e303c7bfd356c4455fde45ca208

[Evan Stade, 2017-02-11 01:38:16]

Description was changed from

==========
Gut ash::MaterialDesignController.

It's not removed completely because IsXXXMaterial() is still used in
many places and serves as a good marker for code cleanup, but it no
longer does anything useful.

A bunch of tests are updated as well to remove parameterization. The
amount of overlap with bug 685837 was not originally intended, but at a
certain point it became easier to keep removing code than to carefully
determine dependencies.

BUG=690048,685837
==========

to

==========
Gut ash::MaterialDesignController, and remove the about:flags entry.

It's not removed completely because IsXXXMaterial() is still used in
many places and serves as a good marker for code cleanup, but it no
longer does anything useful.

A bunch of tests are updated as well to remove parameterization. The
amount of overlap with bug 685837 was not originally intended, but at a
certain point it became easier to keep removing code than to carefully
determine dependencies.

BUG=690048,685837
==========

[Evan Stade, 2017-02-11 01:38:16]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org, varkha@chromium.org

[Evan Stade, 2017-02-11 01:38:22]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 01:39:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 07:40:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 07:40:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Evan Stade, 2017-02-13 17:19:00]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 17:19:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-02-13 17:36:29]

LGTM. I agree it makes sense to rip out the test code in the same CL, no
complaints about that. Thanks!

https://codereview.chromium.org/2692663002/diff/1/ash/common/material_design/...
File ash/common/material_design/material_design_controller.h (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/material_design/...
ash/common/material_design/material_design_controller.h:13: // TODO(estade):
deprecated, remove: crbug.com/690048
optionally also cite crbug.com/690957

https://codereview.chromium.org/2692663002/diff/1/ash/common/shelf/shelf_cons...
File ash/common/shelf/shelf_constants.cc (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/shelf/shelf_cons...
ash/common/shelf/shelf_constants.cc:34: // fixme
nit: Please add TODO(estade) with brief description for anyone who stumbles
across this, you can also cite crbug.com/690957

https://codereview.chromium.org/2692663002/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_constants.cc (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_constants.cc:131: // FIXME
ditto to previous comment in shelf_constants

https://codereview.chromium.org/2692663002/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_selector_item.cc (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_selector_item.cc:676: #if 0
Just delete this code instead.

[Evan Stade, 2017-02-13 17:41:01]

(patch not updated)

https://codereview.chromium.org/2692663002/diff/1/ash/common/shelf/shelf_cons...
File ash/common/shelf/shelf_constants.cc (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/shelf/shelf_cons...
ash/common/shelf/shelf_constants.cc:34: // fixme
On 2017/02/13 17:36:28, tdanderson wrote:
> nit: Please add TODO(estade) with brief description for anyone who stumbles
> across this, you can also cite crbug.com/690957

sorry, fixme is supposed to be a note to myself to add docs or fix the code.

https://codereview.chromium.org/2692663002/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_selector_item.cc (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_selector_item.cc:676: #if 0
On 2017/02/13 17:36:28, tdanderson wrote:
> Just delete this code instead.

there's other related code throughout this file (behind if (shadow_)) -- Valery
are you OK with deleting it all?

[varkha, 2017-02-13 17:44:01]

https://codereview.chromium.org/2692663002/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_selector_item.cc (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_selector_item.cc:676: #if 0
On 2017/02/13 17:41:01, Evan Stade wrote:
> On 2017/02/13 17:36:28, tdanderson wrote:
> > Just delete this code instead.
> 
> there's other related code throughout this file (behind if (shadow_)) --
Valery
> are you OK with deleting it all?

Yes, please go ahead. The shadow was barely visible with the colors we use in
any case.

[Evan Stade, 2017-02-13 17:52:24]

https://codereview.chromium.org/2692663002/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_selector_item.cc (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_selector_item.cc:676: #if 0
On 2017/02/13 17:44:01, varkha wrote:
> On 2017/02/13 17:41:01, Evan Stade wrote:
> > On 2017/02/13 17:36:28, tdanderson wrote:
> > > Just delete this code instead.
> > 
> > there's other related code throughout this file (behind if (shadow_)) --
> Valery
> > are you OK with deleting it all?
> 
> Yes, please go ahead. The shadow was barely visible with the colors we use in
> any case.

indeed, it was supposed to be there for Alt+Tab too but I couldn't see it no
matter how much I squinted so I never added it.

[commit-bot: I haz the power, 2017-02-13 18:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 18:43:11]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-02-13 19:29:42]

https://codereview.chromium.org/2692663002/diff/1/ash/common/material_design/...
File ash/common/material_design/material_design_controller.h (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/material_design/...
ash/common/material_design/material_design_controller.h:13: // TODO(estade):
deprecated, remove: crbug.com/690048
On 2017/02/13 17:36:28, tdanderson wrote:
> optionally also cite crbug.com/690957

Done.

https://codereview.chromium.org/2692663002/diff/1/ash/common/shelf/shelf_cons...
File ash/common/shelf/shelf_constants.cc (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/shelf/shelf_cons...
ash/common/shelf/shelf_constants.cc:34: // fixme
On 2017/02/13 17:41:01, Evan Stade wrote:
> On 2017/02/13 17:36:28, tdanderson wrote:
> > nit: Please add TODO(estade) with brief description for anyone who stumbles
> > across this, you can also cite crbug.com/690957
> 
> sorry, fixme is supposed to be a note to myself to add docs or fix the code.

Done.

https://codereview.chromium.org/2692663002/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_constants.cc (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_constants.cc:131: // FIXME
On 2017/02/13 17:36:28, tdanderson wrote:
> ditto to previous comment in shelf_constants

Done.

https://codereview.chromium.org/2692663002/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_selector_item.cc (right):

https://codereview.chromium.org/2692663002/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_selector_item.cc:676: #if 0
On 2017/02/13 17:52:24, Evan Stade wrote:
> On 2017/02/13 17:44:01, varkha wrote:
> > On 2017/02/13 17:41:01, Evan Stade wrote:
> > > On 2017/02/13 17:36:28, tdanderson wrote:
> > > > Just delete this code instead.
> > > 
> > > there's other related code throughout this file (behind if (shadow_)) --
> > Valery
> > > are you OK with deleting it all?
> > 
> > Yes, please go ahead. The shadow was barely visible with the colors we use
in
> > any case.
> 
> indeed, it was supposed to be there for Alt+Tab too but I couldn't see it no
> matter how much I squinted so I never added it.

Done.

[Evan Stade, 2017-02-13 19:30:06]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 19:30:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-02-13 19:31:55]

estade@chromium.org changed reviewers:
+ derat@chromium.org, thakis@chromium.org

[Evan Stade, 2017-02-13 19:31:56]

+owners, ptal
derat:
  ash/ everything except common
thakis:
  chrome/browser/chrome_browser_main.cc
  chrome/test/base/browser_with_test_window_test.cc
  chrome/test/base/view_event_test_platform_part_chromeos.cc

[commit-bot: I haz the power, 2017-02-13 19:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 19:35:36]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Daniel Erat, 2017-02-13 23:17:02]

lgtm

https://codereview.chromium.org/2692663002/diff/20001/ash/wm/window_state_uni...
File ash/wm/window_state_unittest.cc (right):

https://codereview.chromium.org/2692663002/diff/20001/ash/wm/window_state_uni...
ash/wm/window_state_unittest.cc:329: EXPECT_EQ(gfx::Rect(0, 0, 800,
552).ToString(),
have to admit that i don't like all of these magic numbers, but at least an
offset isn't getting added to them now. :-/

[Evan Stade, 2017-02-13 23:55:38]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 23:56:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 00:45:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 00:45:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Nico, 2017-02-14 16:01:32]

lgtm

[Evan Stade, 2017-02-14 16:35:06]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-02-14 16:35:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2692663002/#ps40001
(title: "rebase again")

[Evan Stade, 2017-02-14 16:35:12]

https://codereview.chromium.org/2692663002/diff/20001/ash/wm/window_state_uni...
File ash/wm/window_state_unittest.cc (right):

https://codereview.chromium.org/2692663002/diff/20001/ash/wm/window_state_uni...
ash/wm/window_state_unittest.cc:329: EXPECT_EQ(gfx::Rect(0, 0, 800,
552).ToString(),
On 2017/02/13 23:17:01, Daniel Erat wrote:
> have to admit that i don't like all of these magic numbers, but at least an
> offset isn't getting added to them now. :-/

yea, not sure why this wasn't always kTestConstant - kProdConstant

[commit-bot: I haz the power, 2017-02-14 16:35:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 16:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 16:45:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2017-02-14 22:54:18]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-02-14 22:54:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, thakis@chromium.org, derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2692663002/#ps60001
(title: "yet another rebase")

[commit-bot: I haz the power, 2017-02-14 22:55:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 00:47:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487112858073610,
"parent_rev": "1645e63d771e2ee049d465ce70bca163fd9f5bcc", "commit_rev":
"a23d6ceb29374e303c7bfd356c4455fde45ca208"}

[commit-bot: I haz the power, 2017-02-15 00:47:57]

Description was changed from

==========
Gut ash::MaterialDesignController, and remove the about:flags entry.

It's not removed completely because IsXXXMaterial() is still used in
many places and serves as a good marker for code cleanup, but it no
longer does anything useful.

A bunch of tests are updated as well to remove parameterization. The
amount of overlap with bug 685837 was not originally intended, but at a
certain point it became easier to keep removing code than to carefully
determine dependencies.

BUG=690048,685837
==========

to

==========
Gut ash::MaterialDesignController, and remove the about:flags entry.

It's not removed completely because IsXXXMaterial() is still used in
many places and serves as a good marker for code cleanup, but it no
longer does anything useful.

A bunch of tests are updated as well to remove parameterization. The
amount of overlap with bug 685837 was not originally intended, but at a
certain point it became easier to keep removing code than to carefully
determine dependencies.

BUG=690048,685837

Review-Url: https://codereview.chromium.org/2692663002
Cr-Commit-Position: refs/heads/master@{#450531}
Committed:
https://chromium.googlesource.com/chromium/src/+/a23d6ceb29374e303c7bfd356c44...
==========

[commit-bot: I haz the power, 2017-02-15 00:47:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a23d6ceb29374e303c7bfd356c44...