Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2308)

Unified Diff: ash/dip_unittest.cc

Issue 2692663002: Gut ash::MaterialDesignController, and remove the about:flags entry. (Closed)
Patch Set: yet another rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/wm/overview/window_selector_item.cc ('k') | ash/display/display_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/dip_unittest.cc
diff --git a/ash/dip_unittest.cc b/ash/dip_unittest.cc
index 3844f773e618a7be928eb62d1641b9ae02112c8c..0e1abed3c4990db5c251bdf3ca12a9c4c0afbb84 100644
--- a/ash/dip_unittest.cc
+++ b/ash/dip_unittest.cc
@@ -5,11 +5,10 @@
#include <algorithm>
#include <vector>
-#include "ash/common/material_design/material_design_controller.h"
#include "ash/common/shelf/shelf_widget.h"
#include "ash/common/shelf/wm_shelf.h"
#include "ash/shell.h"
-#include "ash/test/ash_md_test_base.h"
+#include "ash/test/ash_test_base.h"
#include "ash/wm/window_properties.h"
#include "ash/wm/window_util.h"
#include "base/command_line.h"
@@ -28,18 +27,10 @@
namespace ash {
-using DIPTest = test::AshMDTestBase;
-
-INSTANTIATE_TEST_CASE_P(
- /* prefix intentionally left blank due to only one parameterization */,
- DIPTest,
- testing::Values(MaterialDesignController::NON_MATERIAL,
- MaterialDesignController::MATERIAL_NORMAL,
- MaterialDesignController::MATERIAL_EXPERIMENTAL));
+using DIPTest = test::AshTestBase;
// Test if the WM sets correct work area under different density.
-TEST_P(DIPTest, WorkArea) {
- const int height_offset = GetMdMaximizedWindowHeightOffset();
+TEST_F(DIPTest, WorkArea) {
UpdateDisplay("1000x900*1.0f");
aura::Window* root = Shell::GetPrimaryRootWindow();
@@ -48,9 +39,8 @@ TEST_P(DIPTest, WorkArea) {
EXPECT_EQ("0,0 1000x900", display.bounds().ToString());
gfx::Rect work_area = display.work_area();
- EXPECT_EQ(gfx::Rect(0, 0, 1000, 853 + height_offset).ToString(),
- work_area.ToString());
- EXPECT_EQ(gfx::Insets(0, 0, 47 - height_offset, 0).ToString(),
+ EXPECT_EQ(gfx::Rect(0, 0, 1000, 852).ToString(), work_area.ToString());
+ EXPECT_EQ(gfx::Insets(0, 0, 48, 0).ToString(),
display.bounds().InsetsFrom(work_area).ToString());
UpdateDisplay("2000x1800*2.0f");
@@ -66,9 +56,8 @@ TEST_P(DIPTest, WorkArea) {
// Aura and views coordinates are in DIP, so they their bounds do not change.
EXPECT_EQ("0,0 1000x900", display_2x.bounds().ToString());
work_area = display_2x.work_area();
- EXPECT_EQ(gfx::Rect(0, 0, 1000, 853 + height_offset).ToString(),
- work_area.ToString());
- EXPECT_EQ(gfx::Insets(0, 0, 47 - height_offset, 0).ToString(),
+ EXPECT_EQ(gfx::Rect(0, 0, 1000, 852).ToString(), work_area.ToString());
+ EXPECT_EQ(gfx::Insets(0, 0, 48, 0).ToString(),
display_2x.bounds().InsetsFrom(work_area).ToString());
// Sanity check if the workarea's inset hight is same as
« no previous file with comments | « ash/common/wm/overview/window_selector_item.cc ('k') | ash/display/display_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698