chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc - Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc

Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields. (Closed)

Patch Set: address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc

index 5b7904355e91d282119840380b5f7ec40ec3bf3c..ca360c95ed47b607f9839bca11287aee69cd1bbc 100644

--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc

@@ -50,14 +50,14 @@ void UkmPageLoadMetricsObserver::OnComplete(

void UkmPageLoadMetricsObserver::SendMetricsToUkm(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) {

- if (info.committed_url.is_empty() || !timing.first_contentful_paint)

+ if (!info.did_commit || !timing.first_contentful_paint)

return;

ukm::UkmService* ukm_service = g_browser_process->ukm_service();

DCHECK(ukm_service);

std::unique_ptr<ukm::UkmSource> source = base::MakeUnique<ukm::UkmSource>();

- source->set_committed_url(info.committed_url);

+ source->set_committed_url(info.url);

source->set_first_contentful_paint(timing.first_contentful_paint.value());

ukm_service->RecordSource(std::move(source));