chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc - Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields. (Closed)

Patch Set: address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

index 5e5fa2929513701e05ee5769bba76d96488c0de2..13f70d845fc7443d07374a9d96094ff0bd167969 100644

--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc

@@ -57,7 +57,7 @@ SubresourceFilterMetricsObserver::FlushMetricsOnAppEnterBackground(

// app is about to be backgrounded, as part of the Activity.onPause()

// flow. After this method is invoked, Chrome may be killed without further

// notification, so we record final metrics collected up to this point.

- if (!info.committed_url.is_empty())

+ if (info.did_commit)

OnGoingAway(timing, info);

return STOP_OBSERVING;

}